public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jan Kratochvil <jkratoch@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Milian Wolff <milian.wolff@kdab.com>,
	Wang Nan <wangnan0@huawei.com>
Subject: [PATCH 0/3] perf tools DWARF libunwind: Add callchain order support
Date: Tue, 17 Nov 2015 16:05:36 +0100	[thread overview]
Message-ID: <1447772739-18471-1-git-send-email-jolsa@kernel.org> (raw)

hi,
as reported by Milian, currently for DWARF unwind (both libdw
and libunwind) we display callchain in callee order only.

Adding the support to follow callchain order setup to libunwind
DWARF unwinder, so we could get following output for report:

  $ perf record --call-graph dwarf ls
  ...
  $ perf report --no-children --stdio

    39.26%  ls       libc-2.21.so      [.] __strcoll_l
                 |
                 ---__strcoll_l
                    mpsort_with_tmp
                    mpsort_with_tmp
                    sort_files
                    main
                    __libc_start_main
                    _start
                    0

  $ perf report -g caller --no-children --stdio
    ...
    39.26%  ls       libc-2.21.so      [.] __strcoll_l
                 |
                 ---0
                    _start
                    __libc_start_main
                    main
                    sort_files
                    mpsort_with_tmp
                    mpsort_with_tmp
                    __strcoll_l

Tested on x86_64. The change is in generic code only,
so it should not affect other archs. Still it would be
nice to have some confirmation.. Wang Nan? ;-)

It'd be nice to have this for libdw unwind as well,
but it looks like it's out of reach for perf code.. Jan?

Also available in:
  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
  perf/callchain_1

thanks,
jirka


Cc: Jan Kratochvil <jkratoch@redhat.com>
---
Jiri Olsa (3):
      perf tools: Move initial entry call into get_entries function
      perf tools: Add callchain order support for libunwind DWARF unwinder
      perf test: Add callchain order setup for DWARF unwinder test

 tools/perf/tests/dwarf-unwind.c    | 22 +++++++++++++++++++---
 tools/perf/util/unwind-libunwind.c | 60 +++++++++++++++++++++++++++++++++++++++---------------------
 2 files changed, 58 insertions(+), 24 deletions(-)

             reply	other threads:[~2015-11-17 15:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17 15:05 Jiri Olsa [this message]
2015-11-17 15:05 ` [PATCH 1/3] perf tools: Move initial entry call into get_entries function Jiri Olsa
2015-11-26  8:18   ` [tip:perf/core] perf callchain: " tip-bot for Jiri Olsa
2015-11-17 15:05 ` [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder Jiri Olsa
2015-11-18  4:13   ` Wangnan (F)
2015-11-18  5:41     ` Namhyung Kim
2015-11-18  7:26       ` Wangnan (F)
2015-11-22 15:27         ` Namhyung Kim
2015-11-18  8:25       ` Jiri Olsa
2015-11-18  9:25         ` Namhyung Kim
2015-11-18  8:26       ` Jiri Olsa
2015-11-18  7:52     ` [PATCHv2 " Jiri Olsa
2015-11-18  9:29       ` Wangnan (F)
2015-11-26  8:18       ` [tip:perf/core] perf callchain: Add " tip-bot for Jiri Olsa
2015-11-18  7:54     ` [PATCH 2/3] perf tools: Add callchain " Jiri Olsa
2015-11-18  7:59       ` Wangnan (F)
2015-11-18  8:12       ` Jiri Olsa
2015-11-17 15:05 ` [PATCH 3/3] perf test: Add callchain order setup for DWARF unwinder test Jiri Olsa
2015-11-26  8:19   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-11-18  4:22 ` [PATCH 0/3] perf tools DWARF libunwind: Add callchain order support Wangnan (F)
2015-11-19 11:22 ` [PATCH 4/3] perf tools: Add callchain order support for libdw DWARF unwinder Jiri Olsa
2015-11-19 12:10   ` Wangnan (F)
2015-11-19 12:18     ` Wangnan (F)
2015-11-19 13:01     ` [PATCHv2 " Jiri Olsa
2015-11-26  8:19       ` [tip:perf/core] perf callchain: Add " tip-bot for Jiri Olsa
2015-11-19 19:10 ` [PATCH 0/3] perf tools DWARF libunwind: Add callchain order support Arnaldo Carvalho de Melo
2015-11-20  8:38   ` Jiri Olsa
2015-11-22 19:13   ` Milian Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447772739-18471-1-git-send-email-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jkratoch@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milian.wolff@kdab.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox