From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760837AbbKTQ4Y (ORCPT ); Fri, 20 Nov 2015 11:56:24 -0500 Received: from mga11.intel.com ([192.55.52.93]:53828 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759932AbbKTQ4X (ORCPT ); Fri, 20 Nov 2015 11:56:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,323,1444719600"; d="scan'208";a="855853136" Message-ID: <1448038588.31665.177.camel@linux.intel.com> Subject: Re: [PATCH v1 4/7] test_hexdump: replace magic numbers by their meaning From: Andy Shevchenko To: Rasmus Villemoes Cc: Andrew Morton , linux-kernel@vger.kernel.org Date: Fri, 20 Nov 2015 18:56:28 +0200 In-Reply-To: <87poz6s3mw.fsf@rasmusvillemoes.dk> References: <1447259718-19647-1-git-send-email-andriy.shevchenko@linux.intel.com> <1447259718-19647-5-git-send-email-andriy.shevchenko@linux.intel.com> <87poz6s3mw.fsf@rasmusvillemoes.dk> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-11-19 at 11:08 +0100, Rasmus Villemoes wrote: > On Wed, Nov 11 2015, Andy Shevchenko om> wrote: > > > The magic numbers of the length are converted to their actual > > meaning, such as > > end of the buffer with and without ASCII part. > > > > We don't touch the rest magic constants that will be removed in the > > following > > commits. > > > > Signed-off-by: Andy Shevchenko > > --- > >  lib/test_hexdump.c | 13 +++++++++---- > >  1 file changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c > > index 15a6440..a3e3b01 100644 > > --- a/lib/test_hexdump.c > > +++ b/lib/test_hexdump.c > > @@ -130,18 +130,23 @@ static void __init > > test_hexdump_overflow(size_t buflen, bool ascii) > >  { > >   char buf[TEST_HEXDUMP_BUF_SIZE]; > >   const char *t = test_data_1_le[0]; > > + size_t len = 1; > >   size_t l = buflen; > > + int rs = 16, gs = 1; > > + int ae, he, e, r; > >   bool a; > > - int e, r; > >   > >   memset(buf, ' ', sizeof(buf)); > >   > > - r = hex_dump_to_buffer(data_b, 1, 16, 1, buf, buflen, > > ascii); > > + r = hex_dump_to_buffer(data_b, len, rs, gs, buf, buflen, > > ascii); > > + > > + ae = rs * 2 /* hex */ + rs / gs /* spaces */ + 1 /* space > > */ + len /* ascii */; > > + he = (gs * 2 /* hex */ + 1 /* space */) * len / gs - 1 /* > > no trailing space */; > > This computation seems to rely on len being an exact multiple of gs - > which of course it is in this case. hex_dump_to_buffer also enforces > it by setting groupsize to 1 when it's not the case, but that doesn't > really help us here. So maybe an extra comment would be justified. Agree. A comment would be nice to have. > > Rasmus -- Andy Shevchenko Intel Finland Oy