Re: [PATCH 1/2] cpufreq, intel_pstate, Fix limits->max_policy_pct rounding error

Viresh Kumar
2015-11-20T15:19:53Z

On 20-11-15, 10:10, Prarit Bhargava wrote:
> >> limits->max_policy_pct = clamp_t(int, limits->max_policy_pct, 0 , 100);
> >
> > And put this after the later one ?
> >
> >> + limits->max_policy_pct = DIV_ROUND_UP(policy->max * 100,
> >> + policy->cpuinfo.max_freq);
> >>
> >> /* Normalize user input to [min_policy_pct, max_policy_pct] */
> >> limits->min_perf_pct = max(limits->min_policy_pct,
> >
> > Sure you tested it ? :)
>
> Oops -- and yeah, tested. It works because I rewrite the value of
> max_policy_pct :). I'll repost shortly.

But we aren't doing below anymore, doesn't this change the
calculations at all?

limits->max_policy_pct = clamp_t(int, limits->max_policy_pct, 0 , 100);

--
viresh