Re: [PATCH 0/2] HID: Force feedback support for the Logitech G920 Wheel

Elias Vanderstuyft
2015-11-28T07:53:41Z

On Sat, Nov 21, 2015 at 1:37 PM, Edwin Velds <e.velds@gmail.com> wrote:
> This patch implements force feedback support for the Logitech G920 Driving Force
> Racing Wheel.
>
> This patch is based on the basic G920 support patch by Simon Wood:
> http://www.spinics.net/lists/linux-input/msg42174.html
>
> The first patch splits and renames the HID++ driver (hid-logitech-hidpp.c) into
> a basic header and implementation in order to allow building additional features
> from multiple sources. Since this only satisfies the needs for the FF driver,
> any comments or suggestions are welcome.
>
> The second patch implements all supported force feedback effects. The force
> feedback implementation was not made optional because the G920 (like all
> Logitech wheels) can't function without it due to very stiff to default springs.
>
> Edwin Velds (1):
> HID: Create header for Logitech HID++ driver
> HID: Force feedback support for the Logitech G920
>
> drivers/hid/Makefile | 2 +
> drivers/hid/hid-logitech-hidpp-base.c | 1725 ++++++++++++++++++++++++++++++
> drivers/hid/hid-logitech-hidpp-base.h | 81 ++
> drivers/hid/hid-logitech-hidpp-ff.c | 540 ++++++++++
> drivers/hid/hid-logitech-hidpp-ff.h | 9 +
> drivers/hid/hid-logitech-hidpp.c | 1900 ---------------------------------
> 6 files changed, 2357 insertions(+), 1900 deletions(-)
> create mode 100644 drivers/hid/hid-logitech-hidpp-base.c
> create mode 100644 drivers/hid/hid-logitech-hidpp-base.h
> create mode 100644 drivers/hid/hid-logitech-hidpp-ff.c
> create mode 100644 drivers/hid/hid-logitech-hidpp-ff.h
> delete mode 100644 drivers/hid/hid-logitech-hidpp.c
>
> --
> 2.5.0
>

You have my:
Tested-by: Elias Vanderstuyft <elias.vds@gmail.com>

Note however that at least a V2 can be expected:
I did a review off-list just before this patchset made it to this
mailing list, and not all changes are applied yet.

Thanks,
Elias