Re: [PATCH 0/2] HID: Force feedback support for the Logitech G920 Wheel

Benjamin Tissoires
2015-11-26T15:13:59Z

On Thu, Nov 26, 2015 at 3:42 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Sat, 21 Nov 2015, Edwin Velds wrote:
>
>> This patch implements force feedback support for the Logitech G920 Driving Force
>> Racing Wheel.
>>
>> This patch is based on the basic G920 support patch by Simon Wood:
>> http://www.spinics.net/lists/linux-input/msg42174.html
>
> Simon, it'd be nice if I could get your Tested-by: / Reviewed-by: for
> this.
>

Talking about it, I am not a big fan of renaming hid-logitech-hidpp.c
into hid-logitech-hidpp-base.c. This will just break history for no
reasons.
We could keep it named like that and just add the ff module later.

The other question is why do we need to have the ff module in a
separate file? We generally try to keep the number of file to a small
number, and I am not sure we need to split this for ff only.
I am open to any position in favor of splitting, I am just asking.

Cheers,
Benjamin