From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbbKVRBQ (ORCPT ); Sun, 22 Nov 2015 12:01:16 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35386 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbKVRBL (ORCPT ); Sun, 22 Nov 2015 12:01:11 -0500 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 3/3] staging: most: fix id leak Date: Sun, 22 Nov 2015 22:30:56 +0530 Message-Id: <1448211656-15829-3-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1448211656-15829-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1448211656-15829-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If create_most_inst_obj() fails we returned an error pointer but we missed releasing id. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/mostcore/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index 619d558..6210257 100644 --- a/drivers/staging/most/mostcore/core.c +++ b/drivers/staging/most/mostcore/core.c @@ -1762,6 +1762,7 @@ struct kobject *most_register_interface(struct most_interface *iface) inst = create_most_inst_obj(name); if (!inst) { pr_info("Failed to allocate interface instance\n"); + ida_simple_remove(&mdev_id, id); return ERR_PTR(-ENOMEM); } -- 1.9.1