From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbbKXJdO (ORCPT ); Tue, 24 Nov 2015 04:33:14 -0500 Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:44928 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753620AbbKXJdL (ORCPT ); Tue, 24 Nov 2015 04:33:11 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:3872:3874:4321:4385:5007:6119:6261:7576:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12517:12519:12534:12679:12740:13069:13311:13357:13894:14659:21080:30012:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: table01_55932949f9c28 X-Filterd-Recvd-Size: 2360 Message-ID: <1448357586.14504.12.camel@perches.com> Subject: Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203 From: Joe Perches To: Ching Huang , hch@infradead.org, thenzl@redhat.com, jbottomley@parallels.com, dan.carpenter@oracle.com, agordeev@redhat.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@lst.de Date: Tue, 24 Nov 2015 01:33:06 -0800 In-Reply-To: <1448353024.12861.56.camel@Centos6.3-64> References: <1448353024.12861.56.camel@Centos6.3-64> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.16.5-1ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 Why add the dma_free_coherent to an old data path? Is that a general bug fix that should be backported? btw: the printk above the dma_free_coherent use shouldn't use a \ line continuation. it adds undesired whitespace to the format. > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c [] > @@ -2660,10 +2670,19 @@ static bool arcmsr_hbaB_get_config(struc > iop_firm_version = (char __iomem *)(®->message_rwbuffer[17]);> > /*firm_version,17,68-83*/ > iop_device_map = (char __iomem *)(®->message_rwbuffer[21]);> > /*firm_version,21,84-99*/ > > + arcmsr_wait_firmware_ready(acb); > + writel(ARCMSR_MESSAGE_START_DRIVER_MODE, reg->drv2iop_doorbell); > + if (!arcmsr_hbaB_wait_msgint_ready(acb)) { > + printk(KERN_ERR "arcmsr%d: can't set driver mode.\n", acb->host->host_no); > + goto gcfg1; > + } > writel(ARCMSR_MESSAGE_GET_CONFIG, reg->drv2iop_doorbell); > if (!arcmsr_hbaB_wait_msgint_ready(acb)) { > printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \ > miscellaneous data' timeout \n", acb->host->host_no); > +gcfg1: > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > return false; > } > count = 8;