From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302AbbKYK02 (ORCPT ); Wed, 25 Nov 2015 05:26:28 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36029 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbbKYK0Z (ORCPT ); Wed, 25 Nov 2015 05:26:25 -0500 From: Peng Fan To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: van.freenix@gmail.com, Konrad Rzeszutek Wilk , Boris Ostrovsky , David Vrabel , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC 1/1] xen: block: correct setting for xen_blkif_max_ring_order Date: Wed, 25 Nov 2015 18:26:01 +0800 Message-Id: <1448447161-15464-1-git-send-email-van.freenix@gmail.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to this piece code: " pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER); " if xen_blkif_max_ring_order is bigger that XENBUS_MAX_RING_GRANT_ORDER, need to set xen_blkif_max_ring_order using XENBUS_MAX_RING_GRANT_ORDER, but not 0. Signed-off-by: Peng Fan Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel Cc: "Roger Pau Monné" --- Hi, I am new to xen and reading related soure code, not sure whether this is correct. Please comments. Thanks drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 0823a96..883b9fa 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -2126,7 +2126,7 @@ static int __init xlblk_init(void) if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) { pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER); - xen_blkif_max_ring_order = 0; + xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; } if (!xen_has_pv_disk_devices()) -- 2.6.2