public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Ching Huang <ching2048@areca.com.tw>
Cc: hch@lst.de, hch@infradead.org, thenzl@redhat.com,
	jbottomley@parallels.com, dan.carpenter@oracle.com,
	agordeev@redhat.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, hare@suse.de
Subject: Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
Date: Wed, 25 Nov 2015 12:59:25 +0100	[thread overview]
Message-ID: <1448452765.2877.74.camel@suse.de> (raw)
In-Reply-To: <1448451362.4670.29.camel@Centos6.3-64>

On Wed, 2015-11-25 at 19:36 +0800, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
> 
> Fixed getting wrong configuration data of adapter type B and type D.
> 
> Signed-of-by: Ching Huang <ching2048@areca.com.tw>
> 
> ---
> 
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c
> b/drivers/scsi/arcmsr/arcmsr_hba.c
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c	2015-11-23 16:25:22.000000000
> +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c	2015-11-24 11:35:26.000000000
> +0800
> @@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
>  		acb->firm_model,
>  		acb->firm_version);
>  
> -	acb->signature = readl(&reg->message_rwbuffer[1]);
> +	acb->signature = readl(&reg->message_rwbuffer[0]);
>  	/*firm_signature,1,00-03*/
> -	acb->firm_request_len = readl(&reg->message_rwbuffer[2]);
> +	acb->firm_request_len = readl(&reg->message_rwbuffer[1]);
>  	/*firm_request_len,1,04-07*/
> -	acb->firm_numbers_queue = readl(&reg->message_rwbuffer[3]);
> +	acb->firm_numbers_queue = readl(&reg->message_rwbuffer[2]);
>  	/*firm_numbers_queue,2,08-11*/
> -	acb->firm_sdram_size = readl(&reg->message_rwbuffer[4]);
> +	acb->firm_sdram_size = readl(&reg->message_rwbuffer[3]);
>  	/*firm_sdram_size,3,12-15*/
> -	acb->firm_hd_channels = readl(&reg->message_rwbuffer[5]);
> +	acb->firm_hd_channels = readl(&reg->message_rwbuffer[4]);
>  	/*firm_ide_channels,4,16-19*/
>  	acb->firm_cfg_version = readl(&reg-
> >message_rwbuffer[25]);  /*firm_cfg_version,25,100-103*/
>  	/*firm_ide_channels,4,16-19*/
> @@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
>  		iop_device_map++;
>  		count--;
>  	}
> -	acb->signature = readl(&reg->msgcode_rwbuffer[1]);
> +	acb->signature = readl(&reg->msgcode_rwbuffer[0]);
>  	/*firm_signature,1,00-03*/
> -	acb->firm_request_len = readl(&reg->msgcode_rwbuffer[2]);
> +	acb->firm_request_len = readl(&reg->msgcode_rwbuffer[1]);
>  	/*firm_request_len,1,04-07*/
> -	acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[3]);
> +	acb->firm_numbers_queue = readl(&reg->msgcode_rwbuffer[2]);
>  	/*firm_numbers_queue,2,08-11*/
> -	acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[4]);
> +	acb->firm_sdram_size = readl(&reg->msgcode_rwbuffer[3]);
>  	/*firm_sdram_size,3,12-15*/
> -	acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[5]);
> +	acb->firm_hd_channels = readl(&reg->msgcode_rwbuffer[4]);
>  	/*firm_hd_channels,4,16-19*/
>  	acb->firm_cfg_version = readl(&reg->msgcode_rwbuffer[25]);
>  	pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",
> 
> 

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

  reply	other threads:[~2015-11-25 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 11:36 [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Ching Huang
2015-11-25 11:59 ` Johannes Thumshirn [this message]
2015-11-25 12:04 ` Hannes Reinecke
2015-12-01  0:17 ` Martin K. Petersen
2015-12-01  2:51   ` Ching Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448452765.2877.74.camel@suse.de \
    --to=jthumshirn@suse.de \
    --cc=agordeev@redhat.com \
    --cc=ching2048@areca.com.tw \
    --cc=dan.carpenter@oracle.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox