public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/5] stm/intel_th: Updates for v4.4
@ 2015-11-25 12:34 Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 1/5] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-25 12:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Alexander Shishkin

Hi Greg,

Since [1] hasn't yet found its way to char-misc tree, I'm re-sending
it with a few additions, namely: there is one more Kconfig fix from
Arnd and two PCI IDs that I'm hoping we could also include in this
cycle. Based on char-misc-linus.

[1] http://marc.info/?l=linux-kernel&m=144706387705997

Alexander Shishkin (2):
  intel_th: pci: Add Apollo Lake SOC support
  intel_th: pci: Add Broxton SOC support

Arnd Bergmann (1):
  stm: select CONFIG_SRCU

Geert Uytterhoeven (2):
  stm class: Hide STM-specific options if STM is disabled
  intel_th: INTEL_TH should depend on HAS_DMA

 drivers/hwtracing/intel_th/Kconfig |  1 +
 drivers/hwtracing/intel_th/pci.c   | 10 ++++++++++
 drivers/hwtracing/stm/Kconfig      |  5 +++++
 3 files changed, 16 insertions(+)

-- 
2.6.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/5] stm class: Hide STM-specific options if STM is disabled
  2015-11-25 12:34 [PATCH v2 0/5] stm/intel_th: Updates for v4.4 Alexander Shishkin
@ 2015-11-25 12:34 ` Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 2/5] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-25 12:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Geert Uytterhoeven, Alexander Shishkin

From: Geert Uytterhoeven <geert@linux-m68k.org>

If STM=n, it doesn't make sense to ask about STM_DUMMY and
STM_SOURCE_CONSOLE support, which are not even built when enabled
anyway. Hence hide these options if STM=n.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 83e9f591a5..4c13762f2b 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -8,6 +8,8 @@ config STM
 
 	  Say Y here to enable System Trace Module device support.
 
+if STM
+
 config STM_DUMMY
 	tristate "Dummy STM driver"
 	help
@@ -24,3 +26,5 @@ config STM_SOURCE_CONSOLE
 
 	  If you want to send kernel console messages over STM devices,
 	  say Y.
+
+endif
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/5] intel_th: INTEL_TH should depend on HAS_DMA
  2015-11-25 12:34 [PATCH v2 0/5] stm/intel_th: Updates for v4.4 Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 1/5] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
@ 2015-11-25 12:34 ` Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 3/5] stm: select CONFIG_SRCU Alexander Shishkin
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-25 12:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Geert Uytterhoeven, Alexander Shishkin

From: Geert Uytterhoeven <geert@linux-m68k.org>

If NO_DMA=y:

    ERROR: "dma_free_coherent" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
    ERROR: "dma_alloc_coherent" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
    ERROR: "dma_supported" [drivers/hwtracing/intel_th/intel_th.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/intel_th/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/intel_th/Kconfig b/drivers/hwtracing/intel_th/Kconfig
index b7a9073d96..90b0844093 100644
--- a/drivers/hwtracing/intel_th/Kconfig
+++ b/drivers/hwtracing/intel_th/Kconfig
@@ -1,5 +1,6 @@
 config INTEL_TH
 	tristate "Intel(R) Trace Hub controller"
+	depends on HAS_DMA
 	help
 	  Intel(R) Trace Hub (TH) is a set of hardware blocks (subdevices) that
 	  produce, switch and output trace data from multiple hardware and
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/5] stm: select CONFIG_SRCU
  2015-11-25 12:34 [PATCH v2 0/5] stm/intel_th: Updates for v4.4 Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 1/5] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 2/5] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
@ 2015-11-25 12:34 ` Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 4/5] intel_th: pci: Add Apollo Lake SOC support Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 5/5] intel_th: pci: Add Broxton " Alexander Shishkin
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-25 12:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Arnd Bergmann, Alexander Shishkin

From: Arnd Bergmann <arnd@arndb.de>

The newly added STM code uses SRCU, but does not ensure that
this code is part of the kernel:

drivers/built-in.o: In function `stm_source_link_show':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
drivers/built-in.o: In function `stm_source_link_drop':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'

This adds a Kconfig 'select' statement like all the other SRCU using
drivers have.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 4c13762f2b..e0ac753955 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -1,6 +1,7 @@
 config STM
 	tristate "System Trace Module devices"
 	select CONFIGFS_FS
+	select SRCU
 	help
 	  A System Trace Module (STM) is a device exporting data in System
 	  Trace Protocol (STP) format as defined by MIPI STP standards.
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 4/5] intel_th: pci: Add Apollo Lake SOC support
  2015-11-25 12:34 [PATCH v2 0/5] stm/intel_th: Updates for v4.4 Alexander Shishkin
                   ` (2 preceding siblings ...)
  2015-11-25 12:34 ` [PATCH v2 3/5] stm: select CONFIG_SRCU Alexander Shishkin
@ 2015-11-25 12:34 ` Alexander Shishkin
  2015-11-25 12:34 ` [PATCH v2 5/5] intel_th: pci: Add Broxton " Alexander Shishkin
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-25 12:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Alexander Shishkin

This adds Intel(R) Trace Hub PCI ID for Apollo Lake SOC.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/intel_th/pci.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/intel_th/pci.c b/drivers/hwtracing/intel_th/pci.c
index 641e879360..b5760730e1 100644
--- a/drivers/hwtracing/intel_th/pci.c
+++ b/drivers/hwtracing/intel_th/pci.c
@@ -67,6 +67,11 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xa126),
 		.driver_data = (kernel_ulong_t)0,
 	},
+	{
+		/* Apollo Lake */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x5a8e),
+		.driver_data = (kernel_ulong_t)0,
+	},
 	{ 0 },
 };
 
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 5/5] intel_th: pci: Add Broxton SOC support
  2015-11-25 12:34 [PATCH v2 0/5] stm/intel_th: Updates for v4.4 Alexander Shishkin
                   ` (3 preceding siblings ...)
  2015-11-25 12:34 ` [PATCH v2 4/5] intel_th: pci: Add Apollo Lake SOC support Alexander Shishkin
@ 2015-11-25 12:34 ` Alexander Shishkin
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-25 12:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Alexander Shishkin

This adds Intel(R) Trace Hub PCI ID for Broxton SOC.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/intel_th/pci.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/intel_th/pci.c b/drivers/hwtracing/intel_th/pci.c
index b5760730e1..09017073d7 100644
--- a/drivers/hwtracing/intel_th/pci.c
+++ b/drivers/hwtracing/intel_th/pci.c
@@ -72,6 +72,11 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x5a8e),
 		.driver_data = (kernel_ulong_t)0,
 	},
+	{
+		/* Broxton */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0a80),
+		.driver_data = (kernel_ulong_t)0,
+	},
 	{ 0 },
 };
 
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-11-25 12:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-25 12:34 [PATCH v2 0/5] stm/intel_th: Updates for v4.4 Alexander Shishkin
2015-11-25 12:34 ` [PATCH v2 1/5] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
2015-11-25 12:34 ` [PATCH v2 2/5] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
2015-11-25 12:34 ` [PATCH v2 3/5] stm: select CONFIG_SRCU Alexander Shishkin
2015-11-25 12:34 ` [PATCH v2 4/5] intel_th: pci: Add Apollo Lake SOC support Alexander Shishkin
2015-11-25 12:34 ` [PATCH v2 5/5] intel_th: pci: Add Broxton " Alexander Shishkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox