From: Alex Williamson <alex.williamson@redhat.com>
To: Geliang Tang <geliangtang@163.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] vfio: fix a problematic usage of WARN()
Date: Wed, 25 Nov 2015 06:35:28 -0700 [thread overview]
Message-ID: <1448458528.32118.25.camel@redhat.com> (raw)
In-Reply-To: <e20618e9dd688161c7a539bc041b7951efeac351.1448456395.git.geliangtang@163.com>
On Wed, 2015-11-25 at 21:12 +0800, Geliang Tang wrote:
> WARN() takes a condition and a format string. The condition was
> omitted. So I added it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/vfio/vfio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index de632da..9da0703 100644
> --- a/drivers/vfio/vfio.c
> +++ b/drivers/vfio/vfio.c
> @@ -682,7 +682,7 @@ static int vfio_group_nb_add_dev(struct vfio_group *group, struct device *dev)
> return 0;
>
> /* TODO Prevent device auto probing */
> - WARN("Device %s added to live group %d!\n", dev_name(dev),
> + WARN(1, "Device %s added to live group %d!\n", dev_name(dev),
> iommu_group_id(group->iommu_group));
>
> return 0;
This was already reported and I've got a patch queued to resolve it:
https://www.mail-archive.com/kvm@vger.kernel.org/msg123061.html
Thanks,
Alex
next prev parent reply other threads:[~2015-11-25 13:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:12 [PATCH 1/7] drm/msm/mdp: fix a problematic usage of WARN_ON() Geliang Tang
2015-11-25 13:12 ` [PATCH 2/7] drm/vmwgfx: " Geliang Tang
2015-11-25 13:12 ` [PATCH 3/7] iio: " Geliang Tang
2015-11-25 13:12 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang
2015-11-25 13:12 ` [PATCH 5/7] vfio: fix a problematic usage of WARN() Geliang Tang
2015-11-25 13:12 ` [PATCH 6/7] ARM: davinci: " Geliang Tang
2015-11-25 13:12 ` [PATCH 7/7] powerpc: " Geliang Tang
2015-11-26 5:25 ` Michael Ellerman
2015-11-25 13:39 ` [PATCH 6/7] ARM: davinci: " Arnd Bergmann
2015-11-25 14:13 ` [PATCH v2] " Geliang Tang
2015-11-25 20:21 ` kbuild test robot
2015-11-25 20:28 ` Arnd Bergmann
2015-11-26 0:35 ` [PATCH v3] " Geliang Tang
2015-12-15 9:58 ` Sekhar Nori
2015-11-25 13:35 ` Alex Williamson [this message]
2015-11-25 13:47 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Grumbach, Emmanuel
2015-11-25 13:14 ` [PATCH 3/7] iio: fix a problematic usage of WARN_ON() Lars-Peter Clausen
2015-11-25 15:50 ` [PATCH 2/7] drm/vmwgfx: " Sinclair Yeh
2015-11-26 14:51 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448458528.32118.25.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=geliangtang@163.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox