From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbbKYOdA (ORCPT ); Wed, 25 Nov 2015 09:33:00 -0500 Received: from mga11.intel.com ([192.55.52.93]:29273 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbKYOc6 (ORCPT ); Wed, 25 Nov 2015 09:32:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,342,1444719600"; d="scan'208";a="846872480" Message-ID: <1448461984.15393.53.camel@linux.intel.com> Subject: Re: [PATCH v2 1/1] x86/platform/iosf_mbi: Remove duplicate definitions From: Andy Shevchenko To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Anvin , Wolfram Sang , Zhang Rui , Eduardo Valentin , Hock Leong Kweh Date: Wed, 25 Nov 2015 16:33:04 +0200 In-Reply-To: References: <1447264769-21981-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-11-25 at 15:20 +0100, Thomas Gleixner wrote: > On Wed, 11 Nov 2015, Andy Shevchenko wrote: > > > The read and write opcodes are global for all units on SoC and even > across > > Intel SoCs. Remove duplication of corresponding constants. At the > same time > > convert all current users. > > > > No functional change. > > > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Peter Anvin > > Cc: Wolfram Sang > > Cc: Zhang Rui > > Cc: Eduardo Valentin > > Cc: Hock Leong Kweh Eduardo, Rui, can you provide your ACKs or comments about the patch? > > > > Signed-off-by: Andy Shevchenko > > --- > > Since v1: > > - satisfy kbuild robot > > > >  arch/x86/include/asm/iosf_mbi.h              | 49 +++++----------- > ------ > >  arch/x86/platform/atom/punit_atom_debug.c    |  7 +--- > >  arch/x86/platform/intel-quark/imr.c          | 28 +++++-------- > >  drivers/i2c/busses/i2c-designware-baytrail.c | 17 +++----- > >  drivers/powercap/intel_rapl.c                | 10 ++--- > >  drivers/thermal/intel_quark_dts_thermal.c    | 61 ++++++++++++++ > -------------- > >  drivers/thermal/intel_soc_dts_iosf.c         | 43 ++++++++++---- > ------ > > Hmm. Either we get acks of all maintainers and merge it through > tip/x86/... I prefer this way because… > or we do the following: > > Add the new constants w/o using them in a seperate patch and ship > that > linuswards now. Then the subsystem maintainers can pick the > individual > patches up and after the merge window closes we remove the old > constants in one go. > > Either way works for me. …we are working on another fix which is based also on this patch. Can you provide your ACK if you are okay with the changes to arch/x86 ? > > Thanks, > >         tglx > > -- Andy Shevchenko Intel Finland Oy