Re: [PATCH] scripts: recordmcount: break hardlinks

Steven Rostedt
2015-12-11T15:08:45Z

On Fri, 11 Dec 2015 14:45:41 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Fri, Dec 11, 2015 at 09:31:25AM -0500, Steven Rostedt wrote:
> > On Fri, 11 Dec 2015 12:09:03 +0000
> > Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> >
> > > recordmcount edits the file in-place, which can cause problems when
> > > using ccache in hardlink mode. Arrange for recordmcount to break a
> > > hardlinked object.
> > >
> > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > > ---
> > > Steven, sorry it took a while to get this out...
> >
> > Should this be for stable, or is it fine to just add this to my 4.5
> > queue?
>
> I thought you wanted to test it first - although I've been running with

You're right. I forgot I said that ;-)

> this for a while now, my nightly builds have masked out the mcount
> warning, and I suspect it'll take a while for ccache to purge itself
> of the modified objects.
>
> If you're happy to add a stable tag to it, then please do so.
>

I'm fine with you taking it too, but let me go ahead and run it through
my tests now. I'll let you know the results. Takes several hours.

Thanks,

-- Steve