From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752622AbbKZF42 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Nov 2015 00:56:28 -0500
Received: from smtprelay0092.hostedemail.com ([216.40.44.92]:36393 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752506AbbKZF4Y (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Nov 2015 00:56:24 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4321:5007:6261:7903:7904:7974:10004:10400:10562:10848:11026:11232:11473:11658:11914:12517:12519:12740:13069:13255:13311:13357:14659:21063:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: home53_379ec4f343c3b
X-Filterd-Recvd-Size: 1808
Message-ID: <1448517380.20113.68.camel@perches.com>
Subject: Re: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from
 commit <sha1>' lines
From: Joe Perches <joe@perches.com>
To: Shawn N <shawnn@chromium.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>
Date: Wed, 25 Nov 2015 21:56:20 -0800
In-Reply-To: <CALaWCOOV7EQPQDAJ4y5QmUtj=VqCCh+HOXwgLiPf3QBA3vOB=A@mail.gmail.com>
References: <CALaWCOOV7EQPQDAJ4y5QmUtj=VqCCh+HOXwgLiPf3QBA3vOB=A@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.16.5-1ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-11-25 at 18:15 -0800, Shawn N wrote:
> Hello,
> 
> The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
> a minimum description when citing patches: 'commit <12+ chars of sha1>
> (\"\")'. One (unintended?) consequence of this rule is
> that unmodified 'cherry picked from commit ' (git cherry-pick
> -x) lines are flagged.
> 
> - Is the disallowing of 'cherry picked from commit ' lines by
> GIT_COMMIT_ID working as intended?
> - If yes, would it be acceptable to instead add a new rule with
> clearer error output ("Don't include git cherry-pick -x description
> lines")?
> - If no (and such lines are actually acceptable) then I will just
> patch the GIT_COMMIT_ID rule.
> 
> Thanks,
> 
> Shawn

I think sha1 commit ids should always be followed by a
git commit description.

If that's not the general consensus, it's pretty easy
to change.