From: Joe Perches <joe@perches.com>
To: Ching Huang <ching2048@areca.com.tw>,
thenzl@redhat.com, hch@infradead.org, jbottomley@parallels.com,
dan.carpenter@oracle.com, agordeev@redhat.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hare@suse.de, jthumshirn@suse.de
Cc: hch@lst.de
Subject: Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function
Date: Thu, 26 Nov 2015 11:46:14 -0800 [thread overview]
Message-ID: <1448567174.18647.19.camel@perches.com> (raw)
In-Reply-To: <1448538075.10768.47.camel@Centos6.3-64>
On Thu, 2015-11-26 at 19:41 +0800, Ching Huang wrote:
> split dma resource allocation and io register assignment from get_config to a new function arcmsr_alloc_io_queue.
trivia:
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
[]
> +static bool arcmsr_alloc_io_queue(struct AdapterControlBlock *acb)
> +{
[]
> + dma_coherent = dma_alloc_coherent(&pdev->dev, acb->roundup_ccbsize,
> + &dma_coherent_handle, GFP_KERNEL);
> + if (!dma_coherent){
> + pr_notice("arcmsr%d: DMA allocation failed.\n", acb->host->host_no);
> + return false;
> + }
> + memset(dma_coherent, 0, acb->roundup_ccbsize);
>
There is a dma_zalloc_coherent
(and even more trivially)
Most all of your error messages don't use periods.
next prev parent reply other threads:[~2015-11-26 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 11:41 [PATCH 2/3] arcmsr: Split dma resource allocation to a new function Ching Huang
2015-11-26 19:46 ` Joe Perches [this message]
2015-11-27 2:58 ` Ching Huang
2015-11-27 15:05 ` Tomas Henzl
2015-12-01 13:41 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448567174.18647.19.camel@perches.com \
--to=joe@perches.com \
--cc=agordeev@redhat.com \
--cc=ching2048@areca.com.tw \
--cc=dan.carpenter@oracle.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox