From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 07/10] perf hists browser: Update nr entries regardless of min percent
Date: Fri, 27 Nov 2015 22:22:28 -0300 [thread overview]
Message-ID: <1448673751-20949-8-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1448673751-20949-1-git-send-email-acme@kernel.org>
From: Namhyung Kim <namhyung@kernel.org>
When perf report on TUI was called with -S symbol filter, it should
update nr entries even if min_pcnt is 0. IIRC the reason was to update
nr entries after applying minimum percent threshold. But if symbol
filter was given on command line (with -S option), it should use
hists->nr_non_filtered_entries instead of hists->nr_entries.
So this patch fixes a bug of navigating hists browser that the cursor
goes beyond the number of entries when -S (or similar) option is used.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1448645559-31167-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browsers/hists.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index a211b7b6a81e..dcdcbafb078b 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2055,10 +2055,9 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
SLang_reset_tty();
SLang_init_tty(0, 0, 0);
- if (min_pcnt) {
+ if (min_pcnt)
browser->min_pcnt = min_pcnt;
- hist_browser__update_nr_entries(browser);
- }
+ hist_browser__update_nr_entries(browser);
browser->pstack = pstack__new(3);
if (browser->pstack == NULL)
--
2.1.0
next prev parent reply other threads:[~2015-11-28 1:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 1:22 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 01/10] perf buildid-list: Show running kernel build id fix Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 02/10] perf test: 'unwind' test should create kernel maps Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 03/10] perf list: Add support for PERF_COUNT_SW_BPF_OUT Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 04/10] perf list: Robustify event printing routine Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 05/10] perf report: Show error message when processing sample fails Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 06/10] perf hists: Do not skip elided fields when processing samples Arnaldo Carvalho de Melo
2015-11-28 1:22 ` Arnaldo Carvalho de Melo [this message]
2015-11-28 1:22 ` [PATCH 08/10] tools lib bpf: Collect map definition in bpf_object Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 09/10] tools lib bpf: Extract and collect map names from BPF object file Arnaldo Carvalho de Melo
2015-11-28 1:22 ` [PATCH 10/10] perf bpf: Rename bpf config to program config Arnaldo Carvalho de Melo
2015-11-28 9:50 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar
2015-11-29 13:16 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448673751-20949-8-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).