From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553AbbK3TOi (ORCPT ); Mon, 30 Nov 2015 14:14:38 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:57981 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbbK3TOg (ORCPT ); Mon, 30 Nov 2015 14:14:36 -0500 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: zohar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Message-ID: <1448910806.12924.17.camel@linux.vnet.ibm.com> Subject: Re: [PATCH] evm: EVM_LOAD_X509 depends on EVM From: Mimi Zohar To: Arnd Bergmann Cc: Dmitry Kasatkin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morris , "Serge E. Hallyn" , linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org Date: Mon, 30 Nov 2015 14:13:26 -0500 In-Reply-To: <6677122.Oqut6OGZ1C@wuerfel> References: <6677122.Oqut6OGZ1C@wuerfel> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15113019-0029-0000-0000-00000288C937 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-11-27 at 14:52 +0100, Arnd Bergmann wrote: > The newly added EVM_LOAD_X509 code can be configured even if > CONFIG_EVM is disabled, but that causes a link error: > > security/built-in.o: In function `integrity_load_keys': > digsig_asymmetric.c:(.init.text+0x400): undefined reference to `evm_load_x509' > > This adds a Kconfig dependency to ensure it is only enabled when > CONFIG_EVM is set as well. > > Signed-off-by: Arnd Bergmann > Fixes: 7f753c992343 ("evm: load x509 certificate from the kernel") Thanks for the patch! Mimi > --- > Found on yesterday's linux-next with ARM randconfig builds > > diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig > index b1433e9cd8cb..87e83adf4c6e 100644 > --- a/security/integrity/evm/Kconfig > +++ b/security/integrity/evm/Kconfig > @@ -44,7 +44,7 @@ config EVM_EXTRA_SMACK_XATTRS > > config EVM_LOAD_X509 > bool "Load X509 certificate to the '.evm' trusted keyring" > - depends on INTEGRITY_TRUSTED_KEYRING > + depends on EVM && INTEGRITY_TRUSTED_KEYRING > default n > help > Load X509 certificate to the '.evm' trusted keyring. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >