From: Oliver Neukum <oneukum@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@ti.com>, Vladis Dronov <vdronov@redhat.com>,
USB list <linux-usb@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need
Date: Tue, 01 Dec 2015 08:53:57 +0100 [thread overview]
Message-ID: <1448956437.27886.2.camel@suse.com> (raw)
In-Reply-To: <20151201010909.GA13673@kroah.com>
On Mon, 2015-11-30 at 17:09 -0800, Greg Kroah-Hartman wrote:
> > that would loop through endpoints so that drivers do not have to
> > open-code the loop and we indeed need to fix the drivers that
> blindly
> > grab endpoints at fixed offsets and expect them to be there and have
> > correct types.
>
> Yes, that would work for one single type of endpoint, but lots of
> drivers need/have 2 of the same type/direction, so what would this
> function do then? Error out? Hm, that might work, and it would
> reduce
> a bunch of common code, care to make up a patch for that?
Hi,
in that case let us go the whole way. Give drivers a way to describe
what they need that covers all possibilities up to exactly telling the
core what it expects and in which order and numbers.
Actually that would be better in the interface matching code path.
Regards
Oliver
next prev parent reply other threads:[~2015-12-01 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 21:11 [PATCH] usb: interface: allow drivers declare number of endpoints they need Dmitry Torokhov
2015-11-30 21:39 ` Felipe Balbi
2015-11-30 22:20 ` Dmitry Torokhov
2015-11-30 22:18 ` Greg Kroah-Hartman
2015-11-30 22:56 ` Dmitry Torokhov
2015-11-30 23:36 ` Greg Kroah-Hartman
2015-12-01 0:47 ` Dmitry Torokhov
2015-12-01 1:09 ` Greg Kroah-Hartman
2015-12-01 7:53 ` Oliver Neukum [this message]
2015-12-01 17:07 ` Greg Kroah-Hartman
2015-12-01 19:46 ` Josh Boyer
2015-12-01 19:47 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448956437.27886.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=balbi@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox