Re: [PATCH 16/31] IGET: Stop FreeVXFS from using iget() and read_inode() [try #5]

Andrew Morton
2007-11-06T10:26:05Z

On Thu, 25 Oct 2007 17:35:14 +0100 David Howells <dhowells@redhat.com> wrote:

> Stop the FreeVXFS filesystem from using iget() and read_inode(). Replace
> vxfs_read_inode() with vxfs_iget(), and call that instead of iget().
> vxfs_iget() then uses iget_locked() directly and returns a proper error code
> instead of an inode in the event of an error.
>
> vxfs_fill_super() returns any error incurred when getting the root inode
> instead of EINVAL.

alpha:

fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget'
fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here

Not completely trivial - the ino_t -> unsigned long conversion needs to be
propagated fairly widely in there.

(when should we be using ino_t and when should we be using unsigned long,
anyway?)