Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]

Andrew Morton
2007-10-25T23:47:32Z

On Thu, 25 Oct 2007 16:09:09 -0700
Zach Brown <zach.brown@oracle.com> wrote:

>
> > + * ERR_CAST - Explicitly cast an error-valued pointer to another pointer type
> > + * @ptr: The pointer to cast.
> > + *
> > + * Explicitly cast an error-valued pointer to another pointer type in such a
> > + * way as to make it clear that's what's going on.
> > + */
> > +static inline void *ERR_CAST(const void *ptr)
> > +{
> > + return (void *) ptr;
> > +}
>
> Just to nit, surely you don't need the cast inside the function. The
> casting happens at the call site between the argument and returned pointer.
>

It'll warn without the cast.

btw, nit time. This style:

return (void *)ptr;

outnumbers this style

return (void *) ptr;

by 4 to 1. And I don't find the space attractive, useful or logical,
personally.