linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH 6/7] perf stat: Move enable_on_exec setup under earlier code
Date: Thu,  3 Dec 2015 10:06:45 +0100	[thread overview]
Message-ID: <1449133606-14429-7-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1449133606-14429-1-git-send-email-jolsa@kernel.org>

It's more readable this way and we can save one
perf_evsel__is_group_leader condition in current code.

Link: http://lkml.kernel.org/n/tip-y9s28dql028b0as614rkeul9@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/builtin-stat.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 2e70610649a1..e74712dee242 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -173,17 +173,20 @@ static int create_perf_stat_counter(struct perf_evsel *evsel)
 	 * either manually by us or by kernel via enable_on_exec
 	 * set later.
 	 */
-	if (perf_evsel__is_group_leader(evsel))
+	if (perf_evsel__is_group_leader(evsel)) {
 		attr->disabled = 1;
 
-	if (target__has_cpu(&target))
-		return perf_evsel__open_per_cpu(evsel, perf_evsel__cpus(evsel));
-
-	if (!target__has_task(&target) && perf_evsel__is_group_leader(evsel)) {
-		if (!initial_delay)
+		/*
+		 * In case of initial_delay we enable tracee
+		 * events manually.
+		 */
+		if (target__none(&target) && !initial_delay)
 			attr->enable_on_exec = 1;
 	}
 
+	if (target__has_cpu(&target))
+		return perf_evsel__open_per_cpu(evsel, perf_evsel__cpus(evsel));
+
 	return perf_evsel__open_per_thread(evsel, evsel_list->threads);
 }
 
-- 
2.4.3


  parent reply	other threads:[~2015-12-03  9:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03  9:06 [PATCH 0/7] perf stat: Change event enable code Jiri Olsa
2015-12-03  9:06 ` [PATCH 1/7] perf tools: Use event maps directly in perf_evsel__enable Jiri Olsa
2015-12-08  4:33   ` [tip:perf/core] perf evsel: " tip-bot for Jiri Olsa
2015-12-03  9:06 ` [PATCH 2/7] perf tools: Introduce perf_evsel__disable function Jiri Olsa
2015-12-08  4:33   ` [tip:perf/core] perf evsel: Introduce disable() method tip-bot for Jiri Olsa
2015-12-03  9:06 ` [PATCH 3/7] perf tools: Factor perf_evlist__(enable|disable) functions Jiri Olsa
2015-12-08  4:33   ` [tip:perf/core] perf evlist: " tip-bot for Jiri Olsa
2015-12-03  9:06 ` [PATCH 4/7] perf stat: Use perf_evlist__enable in handle_initial_delay Jiri Olsa
2015-12-08  4:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-03  9:06 ` [PATCH 5/7] perf stat: Create events as disabled Jiri Olsa
2015-12-08  4:34   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-03  9:06 ` Jiri Olsa [this message]
2015-12-08  4:34   ` [tip:perf/core] perf stat: Move enable_on_exec setup under earlier code tip-bot for Jiri Olsa
2015-12-03  9:06 ` [RFC 7/7] perf tools: Remove perf_evlist__(enable|disable)_event functions Jiri Olsa
2015-12-03  9:09 ` [PATCH 0/7] perf stat: Change event enable code Jiri Olsa
2015-12-07 21:09 ` Arnaldo Carvalho de Melo
2015-12-08  7:29   ` Adrian Hunter
2015-12-08 13:53     ` Arnaldo Carvalho de Melo
2015-12-09 13:44       ` Adrian Hunter
2015-12-11 12:42         ` Adrian Hunter
2015-12-16 15:55           ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449133606-14429-7-git-send-email-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).