From: "Geyslan G. Bem" <geyslan@gmail.com>
To: peter.senna@gmail.com
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: host: iounmap before return
Date: Sun, 6 Dec 2015 10:47:55 -0300 [thread overview]
Message-ID: <1449409680-19810-1-git-send-email-geyslan@gmail.com> (raw)
This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not unmapping correctly.
Coccinelle: scripts/coccinelle/free/iounmap.cocci
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index f940056..64150dd 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
/* We're reading garbage from the controller */
dev_warn(&pdev->dev,
"xHCI controller failing to respond");
- return;
+ goto out;
}
if (!ext_cap_offset)
@@ -1062,6 +1062,7 @@ hc_init:
XHCI_MAX_HALT_USEC, val);
}
+out:
iounmap(base);
}
--
2.6.3
next reply other threads:[~2015-12-06 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 13:47 Geyslan G. Bem [this message]
2015-12-07 9:30 ` [PATCH] usb: host: iounmap before return Lu Baolu
2015-12-07 10:26 ` Geyslan G. Bem
2015-12-07 11:37 ` Sergei Shtylyov
2015-12-07 23:39 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449409680-19810-1-git-send-email-geyslan@gmail.com \
--to=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox