From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbbLIAUZ (ORCPT ); Tue, 8 Dec 2015 19:20:25 -0500 Received: from ozlabs.org ([103.22.144.67]:57192 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbbLIAUY (ORCPT ); Tue, 8 Dec 2015 19:20:24 -0500 Message-ID: <1449620422.6028.6.camel@ellerman.id.au> Subject: Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs() From: Michael Ellerman To: Steven Rostedt , LKML , linuxppc-dev@lists.ozlabs.org Cc: chuhu@redhat.com Date: Wed, 09 Dec 2015 11:20:22 +1100 In-Reply-To: <20151208135056.718b7668@gandalf.local.home> References: <20151208135056.718b7668@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-12-08 at 13:50 -0500, Steven Rostedt wrote: > It has come to my attention that kprobe event stack tracing does not > work on powerpc. Yep looks like you're right. I didn't realise it was separate from the regular stack trace stuff. > diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c > index ea43a347a104..0142c86801ba 100644 > --- a/arch/powerpc/kernel/stacktrace.c > +++ b/arch/powerpc/kernel/stacktrace.c > @@ -61,3 +61,10 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) > save_context_stack(trace, tsk->thread.ksp, tsk, 0); > } > EXPORT_SYMBOL_GPL(save_stack_trace_tsk); > + > +void > +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace) > +{ > + save_context_stack(trace, regs->gpr[PT_R1], current, 0); In the kernel we would normally use just '1' here rather than 'PT_R1', but it's not a huge deal. Should I take this via powerpc or do you want it to go in via tracing? cheers