From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753394AbbLIWWU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 17:22:20 -0500
Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:60318 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752725AbbLIWWS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 17:22:18 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3743:3866:3867:3871:3873:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12517:12519:12740:13069:13255:13311:13357:13894:14659:21080:30003:30034:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: debt34_6b2f0733cb512
X-Filterd-Recvd-Size: 1973
Message-ID: <1449699734.25389.79.camel@perches.com>
Subject: Re: [PATCH] hexdump: Add ability to do endian conversions in
 print_hex_dump functions
From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Rob Herring <robh+dt@kernel.org>
Date: Wed, 09 Dec 2015 14:22:14 -0800
In-Reply-To: <CAHp75VekWNpeAaoxjU4uU5B1bqNBA3mXx2PAmeUeqdF-pY+34Q@mail.gmail.com>
References: <CAL_JsqJ0oftptSxyAcGOnQ3XA9v55B2n=8DiWBcErcLKgfsppg@mail.gmail.com>
	 <bc67748274ffac118e61374200256e1ae17acf19.1449697255.git.joe@perches.com>
	 <CAHp75VekWNpeAaoxjU4uU5B1bqNBA3mXx2PAmeUeqdF-pY+34Q@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.2-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-12-10 at 00:11 +0200, Andy Shevchenko wrote:
> On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches <joe@perches.com> wrote:
[]
> > diff --git a/lib/hexdump.c b/lib/hexdump.c
[]
> > @@ -216,7 +240,10 @@ EXPORT_SYMBOL(hex_dump_to_buffer);
> >   * @prefix_type: controls whether prefix of an offset, address, or none
> >   *  is printed (%DUMP_PREFIX_OFFSET, %DUMP_PREFIX_ADDRESS, %DUMP_PREFIX_NONE)
> >   * @rowsize: number of bytes to print per line; must be 16 or 32
> > - * @groupsize: number of bytes to print at a time (1, 2, 4, 8; default = 1)
> > + * @groupflags: number of bytes to print at a time (1, 2, 4, 8; default = 1)
> > + * @groupflags: number of bytes to print at a time (1, 2, 4, 8; default = 1)
> 
> Duplicate.

Ick.  Andrew, can you delete one line please or do you want a resend?