Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma

Peter Senna Tschudin
2015-12-10T10:19:05Z

On Wed, Dec 09, 2015 at 07:32:35PM -0300, Geyslan G. Bem wrote:
> Put space after comma.
>
> This patch also changes QH_NEXT macro for better reading.
>
> Caught by checkpatch: "ERROR: space required after that ','"
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> drivers/usb/host/ehci.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 7b2b213..ea56147 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -334,7 +334,7 @@ struct ehci_qtd {
> /*-------------------------------------------------------------------------*/
>
> /* type tag from {qh,itd,sitd,fstn}->hw_next */
> -#define Q_NEXT_TYPE(ehci,dma) ((dma) & cpu_to_hc32(ehci, 3 << 1))
> +#define Q_NEXT_TYPE(ehci, dma) ((dma) & cpu_to_hc32(ehci, 3 << 1))
>
> /*
> * Now the following defines are not converted using the
> @@ -350,7 +350,8 @@ struct ehci_qtd {
> #define Q_TYPE_FSTN (3 << 1)
>
> /* next async queue entry, or pointer to interrupt/periodic QH */
> -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH))
> +#define QH_NEXT(ehci, dma) \
> + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH))

For the maintainers: Is having two lines here better than having a line with 83 chars?

>
> /* for periodic/async schedules and qtd lists, mark end of list */
> #define EHCI_LIST_END(ehci) cpu_to_hc32(ehci, 1) /* "null pointer" to hw */
> --
> 2.6.3
>