From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions
Date: Wed, 09 Dec 2015 15:15:20 -0800 [thread overview]
Message-ID: <1449702920.25389.90.camel@perches.com> (raw)
In-Reply-To: <CAHp75Vd4em5h71NEt+FTrkuV48qj5TYYLOPNs6JU_74zCxDmFg@mail.gmail.com>
On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote:
> On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches <joe@perches.com> wrote:
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > >
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > >
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> >
> > One comment below and my tag
> > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Couple of additional notes. (Tag still in power)
>
> 1. There is similar to print_hex_dump() function in seq_file. Separate patch?
Let's see if anyone wants this one first.
> 2. What to do with ASCII part? Shall we print it as byte stream?
It's still emitted as a byte stream.
> And one more style comment below.
That one's a nit I don't care about.
next prev parent reply other threads:[~2015-12-09 23:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 16:07 [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Masahiro Yamada
2015-12-08 16:16 ` Joe Perches
2015-12-08 17:03 ` Joe Perches
2015-12-08 21:28 ` Rob Herring
2015-12-09 0:03 ` Joe Perches
2015-12-09 12:03 ` Andy Shevchenko
2015-12-09 19:28 ` Joe Perches
2015-12-09 20:02 ` Andy Shevchenko
2015-12-09 20:09 ` Joe Perches
2015-12-09 20:17 ` Rasmus Villemoes
2015-12-09 20:36 ` Andy Shevchenko
2015-12-09 20:42 ` Joe Perches
2015-12-09 21:59 ` [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions Joe Perches
2015-12-09 22:09 ` Andrew Morton
2015-12-09 22:16 ` Joe Perches
2015-12-09 22:45 ` Andrew Morton
2015-12-09 23:02 ` Joe Perches
2015-12-09 22:11 ` Andy Shevchenko
2015-12-09 22:22 ` Joe Perches
2015-12-09 23:09 ` Andy Shevchenko
2015-12-09 23:15 ` Joe Perches [this message]
2015-12-10 5:55 ` kbuild test robot
2015-12-10 6:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449702920.25389.90.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox