From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754527AbbLIXQ3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 18:16:29 -0500
Received: from smtprelay0088.hostedemail.com ([216.40.44.88]:38784 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754609AbbLIXPX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 18:15:23 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6261:6691:7514:7903:10004:10400:10848:11026:11232:11658:11914:12295:12296:12517:12519:12740:13069:13255:13311:13357:14096:14097:14659:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: smile29_861d0030ccb01
X-Filterd-Recvd-Size: 2288
Message-ID: <1449702920.25389.90.camel@perches.com>
Subject: Re: [PATCH] hexdump: Add ability to do endian conversions in
 print_hex_dump functions
From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Rob Herring <robh+dt@kernel.org>
Date: Wed, 09 Dec 2015 15:15:20 -0800
In-Reply-To: <CAHp75Vd4em5h71NEt+FTrkuV48qj5TYYLOPNs6JU_74zCxDmFg@mail.gmail.com>
References: <CAL_JsqJ0oftptSxyAcGOnQ3XA9v55B2n=8DiWBcErcLKgfsppg@mail.gmail.com>
	 <bc67748274ffac118e61374200256e1ae17acf19.1449697255.git.joe@perches.com>
	 <CAHp75VekWNpeAaoxjU4uU5B1bqNBA3mXx2PAmeUeqdF-pY+34Q@mail.gmail.com>
	 <CAHp75Vd4em5h71NEt+FTrkuV48qj5TYYLOPNs6JU_74zCxDmFg@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.2-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote:
> On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches <joe@perches.com> wrote:
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > > 
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > > 
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> > 
> > One comment below and my tag
> > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Couple of additional notes. (Tag still in power)
> 
> 1. There is similar to print_hex_dump() function in seq_file. Separate patch?

Let's see if anyone wants this one first.

> 2. What to do with ASCII part? Shall we print it as byte stream?

It's still emitted as a byte stream.

> And one more style comment below.

That one's a nit I don't care about.