From: Johannes Berg <johannes@sipsolutions.net>
To: Laura Abbott <labbott@redhat.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Avri Altman <avri.altman@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Suspicious RCU from iwlwifi driver
Date: Fri, 11 Dec 2015 09:00:34 +0100 [thread overview]
Message-ID: <1449820834.2324.0.camel@sipsolutions.net> (raw)
In-Reply-To: <566A0929.2090706@redhat.com>
Hi Laura,
> drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1226 suspicious
> rcu_dereference_protected() usage!
> If I revert 9513c5e18a0dc55a1fc9c890715098ba2315830b
> (iwlwifi: mvm: Avoid dereferencing sta if it was already flushed)
> The warning goes away. Known issue?
Thanks for the report - I at least hadn't seen this (or a fix for it)
yet, we'll take a look.
johannes
next prev parent reply other threads:[~2015-12-11 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 23:22 Suspicious RCU from iwlwifi driver Laura Abbott
2015-12-11 8:00 ` Johannes Berg [this message]
2015-12-11 8:13 ` [PATCH] iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id Johannes Berg
2015-12-11 22:21 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449820834.2324.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=avri.altman@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).