From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbbLKUMX (ORCPT ); Fri, 11 Dec 2015 15:12:23 -0500 Received: from mail-bn1bon0141.outbound.protection.outlook.com ([157.56.111.141]:53728 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752414AbbLKUMV (ORCPT ); Fri, 11 Dec 2015 15:12:21 -0500 Authentication-Results: spf=permerror (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: Lijun Pan To: , , CC: , Lijun Pan Subject: [PATCH RESEND v3] fsl-ifc: add missing include on ARM64 Date: Fri, 11 Dec 2015 13:55:02 -0600 Message-ID: <1449863702-3020-1-git-send-email-Lijun.Pan@freescale.com> X-Mailer: git-send-email 2.3.3 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC013;1:YRbZolL3WIfb72RoFi3ZSnw1iEs04Pf6jjpeOu/UqvNQjz4829r53a3UxxZDdLPFg2djVX6pQyESEVUi21z3JO8nsneOZXoTPu86YytWmXTWauAQ9vxDgqSWFDbLz+YhomeZNCQuwoVpPKZWmJuH9rqIao9DdpSRNNJDcd09oAppCI0ktrUlJa3mlgI61WTPfU4PhQvFZ/bRqv0DBU+i2P9zEOLZzI9Fct0lin4mr5cgLAusn1f9zV27b4NCiGlLMTl3yn7p7DezgFqOoKkAHNFX6dN5XcoyHjYfQEeDB6Bxd+NyTXLKLTAGOfgueDcgWriSZnxX0HnsXanW8d67L8MRo/yGewLlVNHYXDb3D9CRSl4KfkQfbhtaKbZEZcz0LDQNy3JmpZPFtq+wwHsqkyVGH4K1ew7tYawKF9Y2wc4= X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(448002)(199003)(189002)(2201001)(4001430100002)(107886002)(92566002)(19580405001)(87936001)(586003)(19580395003)(50466002)(1220700001)(1096002)(11100500001)(86362001)(85326001)(104016004)(5820100001)(229853001)(77096005)(50226001)(36756003)(6806005)(47776003)(106466001)(5001960100002)(81156007)(23676002)(5008740100001)(5001770100001)(189998001)(97736004)(50986999)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1455;H:tx30smr01.am.freescale.net;FPR:;SPF:PermError;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1455;2:4l/QS65hYGbgNaZ7PUGnBJO5yyQcrGT6Kir2FhyPepc3qrH1EWYC6a/zE05xDpoIHBa2LajrpNjDozGON3yGhQrWhQcH3jc1Q20dp1l6uE+/3xEhdkqxylSrMmR0vGqTWhRDBjhPzqcKR4WmM0ahZA==;3:7IHFtZhps9C2xd7EU6HruACh4LWn5oic22hayo3gbL8J+JsGQeiiVvxtSK4jmHP63hkclsWThRM/vNOK4nTGuJ7X99FaN//GZMGgyjiPOgcbfwGdnfwWpbbCIoaKXkONr6d3H/qIDgc153hnJfXKC8ifgTKusjX8rt73tuyLx1IvOP0/x+zQ0M0AtOxk3nayvDftTm+mlHSKuRwqVUCGMkucaN4D7hZ6U3WCY1aXNvc=;25:HMb6UAjK1lKjaF4v59IAc8m6YcJOYNthO0lR2zcDvZYr7UPCUEkA8ibcb5SJPfXrPHNZCz0hkOxK/h+JomlDabT55W4ylZzeD2BJBOKWk+SLssREuewgojVcbLJr4UED28d8rkl9gwdluIKO69r05bpxPiRGlg0nOAthe4zwq3u5KFuU+iCRY0cTJvrVzEBZlUXD5+d6OTFBb2RNuCFTAw64/sw140YXWOCwEqpK+E2KJDro2Pvgs6/1K1/XdhpSW7FKXxSkPhRfEvUxHGJ7vg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1455; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1455;20:uv0IBli/Hn+DuImLlg/dvkSZX6UtmSwVgeuf4ytNQUtmtqSqkKptc515pcSyU4wlwVuR/axoQpCiDd+3OtapDquaR6M0dCdg3t0ZkLHBaP6HPHQIdNl7x/vaRB3U0mHfy5QTsKR+4ZCAsuvSYv2TtirygM1K0qGvB1agsx1+QKVdoNhB77YUAZjR5eMtzCe38yci2BNV2GSQ9qeevZTHsnGhUiM26g67Di9fncZRwxheD9pyhDmlhlkiupRpKOtpTz2eRhx9NQo7PAT3QSuuJgEwG2+Bryc1qgikiGg532xdnGq8ZqGwowSOynHiZl2vtU20G53YCffLoQ36efj9EzS2739aEnXhdQ9r5qPdHto=;4:0eyHCqfNiX11GY+XZU2bNH8WvCBel2+J3FXjT+ATbfbZQzbCJ1SYooTpo3HG3gKvc3zUfpfGBBwBAzzgSoifogL8VMiS7Rp4morsXV9TF/QO9VDt4ykUyOjno5j/OjWgxu0KijC0houwZ2P2p87HYr5HGhi9V27XBebrLB/vIh5xgOouWXYJp0xBwfgTjRKRIJn+uA3qUF5sFwhPpOHqKid8bGaHuHWyWUnNMTzOb1abl1QXZKzbQ/saZU/eQx1FjPoPEGsfegjpof2UxwKZRYsP9iXF9DkfNHGyKiuvDhiOiUBE7sk/w41bCrZJF1jxo1+Qkyu2zeIrHPTQLdLfhHsrPl+NGA8OlHHXseJfx9WzWXn8PO0hTRoCATIFA/51505kO7cFrPAk7gZ35yPgRINBw8vnwCsxtRRFLeSvibQfrdehd3+3Wq4dQjMX2aP9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR03MB1455;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1455; X-Forefront-PRVS: 0787459938 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDU1OzIzOmNGaFN4djJmMllqTWYwZTUrTlg5K0k0UCtS?= =?utf-8?B?L1g4MFV4WTRWMnU5K3M3T0cyWGcvWFNnWEJnOVl6SDAzYkFFV3d4bzBWYlho?= =?utf-8?B?ME9UTHpUQlRZZTdicXc2V0xhZDVPeCtIdXMxUjgxYklIMS91ZzRoYkwzQk52?= =?utf-8?B?dUJjYWFIL1RMUHFLNmJ5V3dKdWVhVk9PTWVhcmRZTks2c1dZZ1FwbUtucFhY?= =?utf-8?B?U0Fiak1hUi9wd245cEFGazA2Y21ScjI0cXlJdHBBaWh6S2FJaEJna3RYdnlj?= =?utf-8?B?ZUhia2NRY2RDak9OTCtwTkFIQnUwcy93YlhXdndKbTRiSzlZQkNMZnk5NFBH?= =?utf-8?B?bmhZVGIvTUkrbllLemlkTHBZRmoyYm5QcWpub0NLNEtmY01OZjc2elgzNnV2?= =?utf-8?B?aTI5ZFdPVnpPdTA3SURVeDExcm5LTVZtYVFjM3pZQ0NjUFR3amZMK2VrQ2lx?= =?utf-8?B?U2UrQnJ1QStpbEQzdmJYVDV6ajJGMGJFZFhCcklJTnRGZlZOYlM3aWVYcnJv?= =?utf-8?B?VW1NRjVFSXJZMW90TmdIMW1BcVpobWQxK0g0elBna3gxRnlXQjRZMFJ6RERY?= =?utf-8?B?YXNCSDYxcWRocVN6UnJkVEJ5VkFvL0FmQmV5VWwrSUlsOEM4M0wrV3NkcnNo?= =?utf-8?B?akdHclJDbEUvUU1vay8wNE1mQzlPb0pYeS8xQ28wQ3pLaytLbUlZMzloZjZC?= =?utf-8?B?YTdvMGYwK0FkWHlrL0JzRkxUOWIyc2owVmZYSFV6eldmT1VRMU1hVGduY2Zm?= =?utf-8?B?eVJIbG9hTm9xSTlMNlJpMHNWdWw0VEVFTlpPVTRkSmpOUG02c09lWUR2QURh?= =?utf-8?B?R245NzgzUkVoWHM5bHVlNitSbXdvTllVQjZrRGNzVzduTHJ2N25JOWNVNTJC?= =?utf-8?B?QTdLNnVQQ202MWVQM2FJaVo5UjF6aG5WUExGWTZ5UXp3RCtMREs0MU9wek1H?= =?utf-8?B?ak8zNVRncXVSbllQUWNYdmlzb2FNa2x1NmFpa3lyL2dmSWdDRGZWNzFmbmlw?= =?utf-8?B?Q2w3VFdrcWF6eVJXcndrMDUxd2kzUU1mTFRTdDAzekJ0S2VWbjRXcVk4UmxE?= =?utf-8?B?bDN0NGFtL3ZVeCtPQklQdTZza25iNTN2TWI5bitxL285MkEvZnZYMVVqN1RS?= =?utf-8?B?UXVyMmR1ZXlBTzQ5T1pkQTVES3J2bm1sOGhtRTFydEw3UmRyZVNBbWZEQTNm?= =?utf-8?B?Mks0dldHZ2hnSklEeUUvZTFhcnVKL3N2bGs4Z1hjUk9LK0J1SCtEVEhwQjVQ?= =?utf-8?B?QVVteGV1RnZuUWtXUHhmWE8rb3BNZEx4cERpTGpHUmlDTWV0R2pTUkltRlhs?= =?utf-8?B?T204T1d4K3p6ZGUwTEh0Z3VxZndZb2pnZytvYmJHWjNOL3oxeU8xWktYWGlu?= =?utf-8?Q?3/acktF5?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1455;5:SzuOrx4lSi5AULyDJXujeHa5hGrBLdEYE26vl+I5GRxrJwo5AxMn5bn+Uld8AKarZICV7fEzhqDmKAvkWtGVfIKB3BtFL6V97e3JX2VwSylFF3dXgwiPD2Kvkm0yjEQ3eAlgXxSq0Nz4bpJRfbB5kg==;24:wgBzC7QyLUbsJZzczYKbT+PTk/9Hr6WKmmYnRTSasgosTA9bRiJNTWovsy4VqU265FfNhMka9Pe0q7DapK41YaC65aG2pvXGfCmrwU2avTo= X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2015 20:12:18.3762 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1455 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Need to include sched.h to fix the following compilation error if FSL_IFC is enabled on ARM64 machine. In file included from include/linux/mmzone.h:9:0, from include/linux/gfp.h:5, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/memory/fsl_ifc.c:22: drivers/memory/fsl_ifc.c: In function ‘check_nand_stat’: include/linux/wait.h:165:35: error: ‘TASK_NORMAL’ undeclared (first use in this function) #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL) ^ drivers/memory/fsl_ifc.c:136:3: note: in expansion of macro ‘wake_up’ wake_up(&ctrl->nand_wait); ^ include/linux/wait.h:165:35: note: each undeclared identifier is reported only once for each function it appears in #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL) ^ drivers/memory/fsl_ifc.c:136:3: note: in expansion of macro ‘wake_up’ wake_up(&ctrl->nand_wait); ^ Analysis is as follows: I put some instrumental code and get the following .h files inclusion sequence: In file included from ./arch/arm64/include/asm/compat.h:25:0, from ./arch/arm64/include/asm/stat.h:23, from include/linux/stat.h:5, from include/linux/module.h:10, from drivers/memory/fsl_ifc.c:23: include/linux/sched.h:113:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘struct’ struct sched_attr { ^ CONFIG_COMPAT=y is enabled while 39 and 48 bit VA is selected. When 42 bit VA is selected, it does not enable CONFIG_COMPAT=y In ./arch/arm64/include/asm/stat.h:23, it has "#ifdef CONFIG_COMPAT" "#include " "..." "#endif" Since ./arch/arm64/include/asm/stat.h does not include ./arch/arm64/include/asm/compat.h, then it will not include include/linux/sched.h Hence we have to manually add "#include " in drivers/memory/fsl_ifc.c Signed-off-by: Lijun Pan --- v3: change the subject title to better reflect the commit message insert linux/sched.h in more appropriate place among all .h files articulate CONFIG_COMPAT=y is set in 39/48 bit VA v2: reordering the include .h files according to Arnd's suggestion detailing why linux/sched.h is needed. drivers/memory/fsl_ifc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c index e87459f..acd1460 100644 --- a/drivers/memory/fsl_ifc.c +++ b/drivers/memory/fsl_ifc.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include -- 2.3.3