From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbbLKT45 (ORCPT ); Fri, 11 Dec 2015 14:56:57 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38808 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbbLKT44 (ORCPT ); Fri, 11 Dec 2015 14:56:56 -0500 From: David Eccher To: Felipe Balbi Cc: Greg Kroah-Hartman , Al Viro , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, David Eccher Subject: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write Date: Fri, 11 Dec 2015 20:56:26 +0100 Message-Id: <1449863786-7697-1-git-send-email-d.eccher@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index f454c7a..b968c25 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -1144,6 +1144,7 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) } else retval = len; + spin_lock_irq (&dev->lock); return retval; } -- 1.8.1.2