From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbbLLOr0 (ORCPT ); Sat, 12 Dec 2015 09:47:26 -0500 Received: from mail-oi0-f51.google.com ([209.85.218.51]:34113 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbbLLOrY (ORCPT ); Sat, 12 Dec 2015 09:47:24 -0500 From: Benjamin Young Cc: Benjamin Young , Greg Kroah-Hartman , tolga ceylan , "Ravindran, Madhusudhanan (M.)" , devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with ! Date: Sat, 12 Dec 2015 06:45:59 -0800 Message-Id: <1449931562-23133-1-git-send-email-youngcdev@gmail.com> X-Mailer: git-send-email 2.5.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed coding style for null comparisons in netlogic driver to be more consistant with the rest of the kernel coding style Signed-off-by: Benjamin Young --- drivers/staging/netlogic/xlr_net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index 8ae0175..ac93e63 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/staging/netlogic/xlr_net.c @@ -147,7 +147,7 @@ static void xlr_net_fmn_handler(int bkt, int src_stnid, int size, addr = addr - MAC_SKB_BACK_PTR_SIZE; skb = (struct sk_buff *) *(unsigned long *)addr; skb->dev = adapter->netdev[port]; - if (skb->dev == NULL) + if (!skb->dev) return; ndev = skb->dev; priv = netdev_priv(ndev); @@ -878,7 +878,7 @@ static int xlr_setup_mdio(struct xlr_net_priv *priv, priv->mii_bus->write = xlr_mii_write; priv->mii_bus->parent = &pdev->dev; priv->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL); - if (priv->mii_bus->irq == NULL) { + if (!priv->mii_bus->irq) { pr_err("irq alloc failed\n"); mdiobus_free(priv->mii_bus); return -ENOMEM; @@ -1037,7 +1037,7 @@ static int xlr_net_probe(struct platform_device *pdev) priv->nd = (struct xlr_net_data *)pdev->dev.platform_data; res = platform_get_resource(pdev, IORESOURCE_MEM, port); - if (res == NULL) { + if (!res) { pr_err("No memory resource for MAC %d\n", priv->port_id); err = -ENODEV; @@ -1052,7 +1052,7 @@ static int xlr_net_probe(struct platform_device *pdev) adapter->netdev[port] = ndev; res = platform_get_resource(pdev, IORESOURCE_IRQ, port); - if (res == NULL) { + if (!res) { pr_err("No irq resource for MAC %d\n", priv->port_id); err = -ENODEV; goto err_gmac; -- 2.5.0