From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org, Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH 0/3] Remove ASYNC_CLOSING
Date: Sat, 12 Dec 2015 13:49:33 -0800 [thread overview]
Message-ID: <1449956976-4784-1-git-send-email-peter@hurleysoftware.com> (raw)
Hi Greg,
This series removes ASYNC_CLOSING from kernel use. However, the definition
is in a uapi header so I think it needs to stay.
The mxser driver used ASYNC_CLOSING to purge its fifo _with each
byte received_ while closing. This is clearly unnecessary but the
hangup/shutdown sequence in that driver is spaghetti and I don't have
the hardware to test (what I would consider to be) the proper fix:
cleaning up its hangup/shutdown so that clearing the fifo can be
done once in shutdown.
The isdn subsystem used ASYNC_CLOSING for unclear purposes; the
immediate effect was to prevent sending AT commands from the
emulator, but its not clear why that's necessary when closing.
Since idsn does not use the tty_port helpers, I simply added
to isdn the equivalent of an ASYNC_CLOSING flag.
Regards,
Peter Hurley (3):
tty: mxser: Remove ASYNC_CLOSING
isdn: Remove ASYNC_CLOSING
tty: Remove ASYNC_CLOSING
drivers/isdn/i4l/isdn_tty.c | 12 ++++++------
drivers/s390/char/con3215.c | 3 +--
drivers/tty/mxser.c | 9 +++++----
drivers/tty/rocket.c | 2 +-
drivers/tty/serial/68328serial.c | 3 +--
drivers/tty/serial/crisv10.c | 3 +--
drivers/tty/serial/serial_core.c | 1 -
drivers/tty/tty_port.c | 3 +--
include/linux/isdn.h | 1 +
net/irda/ircomm/ircomm_tty.c | 4 ----
10 files changed, 17 insertions(+), 24 deletions(-)
--
2.6.3
next reply other threads:[~2015-12-12 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 21:49 Peter Hurley [this message]
2015-12-12 21:49 ` [PATCH 1/3] tty: mxser: Remove ASYNC_CLOSING Peter Hurley
2015-12-12 21:49 ` [PATCH 2/3] isdn: " Peter Hurley
2015-12-12 21:49 ` [PATCH 3/3] tty: " Peter Hurley
2016-01-10 22:51 ` [PATCH v2 0/3] " Peter Hurley
2016-01-10 22:51 ` [PATCH v2 1/3] tty: mxser: " Peter Hurley
2016-01-10 22:51 ` [PATCH v2 2/3] isdn: " Peter Hurley
2016-01-10 22:51 ` [PATCH v2 3/3] tty: " Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449956976-4784-1-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox