From: "Geyslan G. Bem" <geyslan@gmail.com>
To: peter.senna@gmail.com
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v3 07/10] usb: host: ehci-sched: use C89-style comments
Date: Sun, 13 Dec 2015 13:59:36 -0300 [thread overview]
Message-ID: <1450025981-23398-8-git-send-email-geyslan@gmail.com> (raw)
In-Reply-To: <1450025981-23398-1-git-send-email-geyslan@gmail.com>
This patch changes comments conforming coding style.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
drivers/usb/host/ehci-sched.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 31f522a..2705c0b 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -52,7 +52,7 @@ periodic_next_shadow(struct ehci_hcd *ehci, union ehci_shadow *periodic,
return &periodic->fstn->fstn_next;
case Q_TYPE_ITD:
return &periodic->itd->itd_next;
- // case Q_TYPE_SITD:
+ /* case Q_TYPE_SITD: */
default:
return &periodic->sitd->sitd_next;
}
@@ -491,7 +491,7 @@ static int tt_no_collision(
type = Q_NEXT_TYPE(ehci, here.sitd->hw_next);
here = here.sitd->sitd_next;
continue;
- // case Q_TYPE_FSTN:
+ /* case Q_TYPE_FSTN: */
default:
ehci_dbg(ehci,
"periodic frame %d bogus type %d\n",
@@ -784,7 +784,7 @@ static int check_period(
return 0;
}
- // success!
+ /* success! */
return 1;
}
@@ -1254,7 +1254,7 @@ iso_sched_free(
{
if (!iso_sched)
return;
- // caller must hold ehci->lock!
+ /* caller must hold ehci->lock! */
list_splice(&iso_sched->td_list, &stream->free_list);
kfree(iso_sched);
}
@@ -1715,7 +1715,7 @@ itd_patch(
struct ehci_iso_packet *uf = &iso_sched->packet[index];
unsigned pg = itd->pg;
- // BUG_ON (pg == 6 && uf->cross);
+ /* BUG_ON(pg == 6 && uf->cross); */
uframe &= 0x07;
itd->index[uframe] = index;
@@ -1792,7 +1792,7 @@ static void itd_link_urb(
packet < urb->number_of_packets;) {
if (itd == NULL) {
/* ASSERT: we have all necessary itds */
- // BUG_ON (list_empty (&iso_sched->td_list));
+ /* BUG_ON(list_empty(&iso_sched->td_list)); */
/* ASSERT: no itds for this endpoint in this uframe */
@@ -1894,9 +1894,10 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
if (likely((urb_index + 1) != urb->number_of_packets))
goto done;
- /* ASSERT: it's really the last itd for this urb
- list_for_each_entry (itd, &stream->td_list, itd_list)
- BUG_ON (itd->urb == urb);
+ /*
+ * ASSERT: it's really the last itd for this urb
+ * list_for_each_entry (itd, &stream->td_list, itd_list)
+ * BUG_ON(itd->urb == urb);
*/
/* give urb back to the driver; completion often (re)submits */
@@ -2275,9 +2276,10 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
if ((urb_index + 1) != urb->number_of_packets)
goto done;
- /* ASSERT: it's really the last sitd for this urb
- list_for_each_entry (sitd, &stream->td_list, sitd_list)
- BUG_ON (sitd->urb == urb);
+ /*
+ * ASSERT: it's really the last sitd for this urb
+ * list_for_each_entry (sitd, &stream->td_list, sitd_list)
+ * BUG_ON(sitd->urb == urb);
*/
/* give urb back to the driver; completion often (re)submits */
--
2.6.3
next prev parent reply other threads:[~2015-12-13 17:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 16:59 [PATCH v3 00/10] usb: host: ehci-sched: cleanup Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 01/10] usb: host: ehci-sched: refactor scan_isoc function Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 02/10] usb: host: ehci-sched: move constants to right Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 03/10] usb: host: ehci-sched: remove useless initializations Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 04/10] usb: host: ehci-sched: add spaces around operators Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 05/10] usb: host: ehci-sched: remove prohibited spaces Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 06/10] usb: host: ehci-sched: remove useless else branch Geyslan G. Bem
2015-12-13 16:59 ` Geyslan G. Bem [this message]
2015-12-13 16:59 ` [PATCH v3 08/10] usb: host: ehci-sched: add line after declarations Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 09/10] usb: host: ehci-sched: use sizeof operator with parens Geyslan G. Bem
2015-12-13 16:59 ` [PATCH v3 10/10] usb: host: ehci-sched: remove unnecessary braces Geyslan G. Bem
2015-12-24 16:03 ` [PATCH v3 00/10] usb: host: ehci-sched: cleanup Geyslan G. Bem
2016-01-25 3:30 ` Greg Kroah-Hartman
2016-01-25 19:52 ` Geyslan G. Bem
2016-01-25 19:56 ` Greg Kroah-Hartman
2016-01-25 20:20 ` Geyslan G. Bem
2016-01-25 20:08 ` Alan Stern
2016-01-25 20:26 ` Geyslan G. Bem
2016-01-25 20:40 ` Alan Stern
2016-01-25 22:18 ` Geyslan G. Bem
2016-01-26 1:49 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450025981-23398-8-git-send-email-geyslan@gmail.com \
--to=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).