From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Jens Axboe <axboe@kernel.dk>, Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH 0/3] block: avoid module usage in non-modular code
Date: Sun, 13 Dec 2015 15:04:01 -0500 [thread overview]
Message-ID: <1450037044-27628-1-git-send-email-paul.gortmaker@windriver.com> (raw)
This series of commits is a part of a larger project to ensure
people don't reference modular support functions in non-modular
code. Overall there was roughly 5k lines of dead code in the
kernel due to this. So far we've fixed several areas, like tty,
x86, net, ... and we continue to work on other areas.
There are several reasons to not use module support for code that
can never be built as a module, but the big ones are:
(1) it is easy to accidentally code up unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be
modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn
includes nearly everything else.
The block layer is an easy one as far as this cleanup goes. Only three
files touched, and two of the three don't even change the compiled
objects -- only the noop-iosched had an unused exit function removed.
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Vivek Goyal <vgoyal@redhat.com>
Paul Gortmaker (3):
block: make genhd.c slightly more explicitly non-modular
block: make blk-throttle.c explicitly non-modular
block: make noop-iosched.c explicitly non-modular
block/blk-throttle.c | 5 ++---
block/genhd.c | 2 +-
block/noop-iosched.c | 19 ++++---------------
3 files changed, 7 insertions(+), 19 deletions(-)
--
2.6.1
next reply other threads:[~2015-12-13 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 20:04 Paul Gortmaker [this message]
2015-12-13 20:04 ` [PATCH 1/3] block: make genhd.c slightly more explicitly non-modular Paul Gortmaker
2015-12-13 20:04 ` [PATCH 2/3] block: make blk-throttle.c " Paul Gortmaker
2015-12-15 13:30 ` Vivek Goyal
2015-12-13 20:04 ` [PATCH 3/3] block: make noop-iosched.c " Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450037044-27628-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox