From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 3/3] block: make noop-iosched.c explicitly non-modular
Date: Sun, 13 Dec 2015 15:04:04 -0500 [thread overview]
Message-ID: <1450037044-27628-4-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1450037044-27628-1-git-send-email-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
config IOSCHED_NOOP
bool
default y
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
We also delete the MODULE_LICENSE tag etc. since all that information
is now contained at the top of the file in the comments.
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
block/noop-iosched.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/block/noop-iosched.c b/block/noop-iosched.c
index a163c487cf38..09f089ee7668 100644
--- a/block/noop-iosched.c
+++ b/block/noop-iosched.c
@@ -1,10 +1,11 @@
/*
- * elevator noop
+ * elevator noop: No-op IO scheduler
+ * Author: Jens Axboe
+ * License: GPL
*/
#include <linux/blkdev.h>
#include <linux/elevator.h>
#include <linux/bio.h>
-#include <linux/module.h>
#include <linux/slab.h>
#include <linux/init.h>
@@ -109,16 +110,4 @@ static int __init noop_init(void)
{
return elv_register(&elevator_noop);
}
-
-static void __exit noop_exit(void)
-{
- elv_unregister(&elevator_noop);
-}
-
-module_init(noop_init);
-module_exit(noop_exit);
-
-
-MODULE_AUTHOR("Jens Axboe");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("No-op IO scheduler");
+device_initcall(noop_init);
--
2.6.1
prev parent reply other threads:[~2015-12-13 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 20:04 [PATCH 0/3] block: avoid module usage in non-modular code Paul Gortmaker
2015-12-13 20:04 ` [PATCH 1/3] block: make genhd.c slightly more explicitly non-modular Paul Gortmaker
2015-12-13 20:04 ` [PATCH 2/3] block: make blk-throttle.c " Paul Gortmaker
2015-12-15 13:30 ` Vivek Goyal
2015-12-13 20:04 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450037044-27628-4-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox