From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932940AbbLNWbo (ORCPT ); Mon, 14 Dec 2015 17:31:44 -0500 Received: from p3plsmtps2ded04.prod.phx3.secureserver.net ([208.109.80.198]:54464 "EHLO p3plsmtps2ded04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656AbbLNW2X (ORCPT ); Mon, 14 Dec 2015 17:28:23 -0500 x-originating-ip: 72.167.245.219 From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Cc: "K. Y. Srinivasan" Subject: [PATCH RESEND 11/27] Drivers: hv: vss: run only on supported host versions Date: Mon, 14 Dec 2015 16:01:42 -0800 Message-Id: <1450137718-26366-11-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1450137718-26366-1-git-send-email-kys@microsoft.com> References: <1450137698-26327-1-git-send-email-kys@microsoft.com> <1450137718-26366-1-git-send-email-kys@microsoft.com> X-CMAE-Envelope: MS4wfHH6iDonfJw9CcGhY3YCY901K5anvvFkU9YearuS/IE0eMubsXlfHmmU9udizns57MGvcgZSKk5W5GrMqgv6b/sKsgkodQR/5flotvYN54pkQ2cmJpaM wCVEs3b/0bAIDxjf6K9RII0qylMV44mmcn4VXOOn1BKXkzNoKnNXaZsVCF43PD0LNcnsk/uk4DhZEFWUneou3hdJPtUXiE4WD3AthPtlZSmbu2SVNMPCrA4q uVWt5Y8J8alToW0hMkES/3rHAKeKxozR72BIngFOjnRqJ3c2NIn9XB42iwz86Vdz4Zy63Z1JELEX0WSMU9N6zM5ga8V9RjBKNehNpngrr6W7WUNrH9gTl+Ty sryZqSynT9T+b1x2Vf2Z/EYWvDYoY8KSetrzOvyjXhDBUUpYLG90yO/CMm0nJC0Z7SHd0kgw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olaf Hering The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an empty icframe_vercnt/icmsg_vercnt. But the host ignores that and continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird errors during boot and general misbehaviour. Check the Windows version to work around the host bug, skip hv_vss_init on WS2012 and older. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_snapshot.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index a548ae4..81882d4 100644 --- a/drivers/hv/hv_snapshot.c +++ b/drivers/hv/hv_snapshot.c @@ -331,6 +331,11 @@ static void vss_on_reset(void) int hv_vss_init(struct hv_util_service *srv) { + if (vmbus_proto_version < VERSION_WIN8_1) { + pr_warn("Integration service 'Backup (volume snapshot)'" + " not supported on this host version.\n"); + return -ENOTSUPP; + } recv_buffer = srv->recv_buffer; /* -- 1.7.4.1