From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932756AbbLNW20 (ORCPT ); Mon, 14 Dec 2015 17:28:26 -0500 Received: from p3plsmtps2ded03.prod.phx3.secureserver.net ([208.109.80.60]:55337 "EHLO p3plsmtps2ded03.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600AbbLNW2W (ORCPT ); Mon, 14 Dec 2015 17:28:22 -0500 x-originating-ip: 72.167.245.219 From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Cc: "K. Y. Srinivasan" Subject: [PATCH RESEND 06/27] Drivers: hv: utils: use memdup_user in hvt_op_write Date: Mon, 14 Dec 2015 16:01:37 -0800 Message-Id: <1450137718-26366-6-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1450137718-26366-1-git-send-email-kys@microsoft.com> References: <1450137698-26327-1-git-send-email-kys@microsoft.com> <1450137718-26366-1-git-send-email-kys@microsoft.com> X-CMAE-Envelope: MS4wfKWS+k/TzIRqqUgOZajQz4GeoVM+oEN+UwL+BfVsGJqlcf6laA94VDr/XsqfuzCgAnOuqec7lTWXJBtHSgka4oDlLbaabkXAiuFYG42TdfFawgPdHkfF Wt0ZjYGBxnWrj5DNu/8iThn/ayBCF52DGoCYg0tVtETlG1pwygeoDezYd8oFbTrJ3PYhd39iuHObNq3Gz/fXQtj0IXe5OoS7+wRvTXZ8z6BHaD+qq8iLNXd8 50+qjHBwg+M24l2h0l0Fe/cUrhFEYijrx2D2vgYMrzFQWGy5Uo5J33YGzC8YsI3MUBAlNouyzmzcBHLiC8UBuaHATwm2qhOVth83fNrlZAlz5knh+/M1f/pE 0u7GYvl7/8TVgObltShLKy+6dHu4Wb9hPRXK54hnd0U1vfqTlh86KD+/EwMolbgW1hb0qupK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olaf Hering Use memdup_user to handle OOM. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_utils_transport.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c index 1505ee6..24b2766 100644 --- a/drivers/hv/hv_utils_transport.c +++ b/drivers/hv/hv_utils_transport.c @@ -80,11 +80,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf, hvt = container_of(file->f_op, struct hvutil_transport, fops); - inmsg = kzalloc(count, GFP_KERNEL); - if (copy_from_user(inmsg, buf, count)) { - kfree(inmsg); - return -EFAULT; - } + inmsg = memdup_user(buf, count); + if (IS_ERR(inmsg)) + return PTR_ERR(inmsg); + if (hvt->on_msg(inmsg, count)) return -EFAULT; kfree(inmsg); -- 1.7.4.1