From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933538AbbLOSOx (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 13:14:53 -0500
Received: from youngberry.canonical.com ([91.189.89.112]:39337 "EHLO
	youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932199AbbLOSOw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 13:14:52 -0500
Message-ID: <1450203285.23773.15.camel@fourier>
Subject: Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with
 __EXPORTED_HEADERS__
From: Kamal Mostafa <kamal@canonical.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>, linux-kernel@vger.kernel.org,
        devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
        vkuznets@redhat.com, jasowang@redhat.com
Date: Tue, 15 Dec 2015 10:14:45 -0800
In-Reply-To: <20151215031109.GB4040@kroah.com>
References: <1450137698-26327-1-git-send-email-kys@microsoft.com>
	 <1450137718-26366-1-git-send-email-kys@microsoft.com>
	 <1450137718-26366-22-git-send-email-kys@microsoft.com>
	 <20151215031109.GB4040@kroah.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2015-12-14 at 19:11 -0800, Greg KH wrote:
> On Mon, Dec 14, 2015 at 04:01:53PM -0800, K. Y. Srinivasan wrote:
> > From: Kamal Mostafa <kamal@canonical.com>
> > 
> > Use the local uapi headers to keep in sync with "recently" added #define's
> > (e.g. VSS_OP_REGISTER1).
> > 
> > Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb
> 
> Please use the "correct" way of listing this:
> 	3eb2094c59e8 ("Adding makefile for tools/hv")
> 
> And as this is an old kernel, shouldn't it go into stable releases?

Yes it should.  I'll resubmit with Cc: stable and correct the Fixes
line.

>   Or
> does that mean that no one really ever runs into this issue?
> 
> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  tools/hv/Makefile |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> > index a8ab795..a8c4644 100644
> > --- a/tools/hv/Makefile
> > +++ b/tools/hv/Makefile
> > @@ -5,6 +5,8 @@ PTHREAD_LIBS = -lpthread
> >  WARNINGS = -Wall -Wextra
> >  CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS) $(shell getconf LFS_CFLAGS)
> >  
> > +CFLAGS += -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include
> 
> Why do you need ../../include also?

Because include/uapi/linux/stddef.h includes linux/compiler.h, so
omitting ../../include yields:

gcc -Wall -Wextra -g -lpthread  -D__EXPORTED_HEADERS__ -I../../include/uapi  -o hv_kvp_daemon hv_kvp_daemon.c
In file included from ../../include/uapi/linux/posix_types.h:4:0,
                 from ../../include/uapi/linux/types.h:13,
                 from ../../include/uapi/linux/uuid.h:24,
                 from ../../include/uapi/linux/hyperv.h:28,
                 from hv_kvp_daemon.c:36:
../../include/uapi/linux/stddef.h:1:28: fatal error: linux/compiler.h: No such file or directory
 #include <linux/compiler.h>
                            ^

 -Kamal