From: Joe Perches <joe@perches.com>
To: Chen Gang <chengang@emindsoft.com.cn>,
Arnd Bergmann <arnd@arndb.de>,
trivial@kernel.org
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h
Date: Tue, 15 Dec 2015 12:26:44 -0800 [thread overview]
Message-ID: <1450211204.4142.30.camel@perches.com> (raw)
In-Reply-To: <56702088.9080605@emindsoft.com.cn>
On Tue, 2015-12-15 at 22:15 +0800, Chen Gang wrote:
> It is a trivial patch.
[]
> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
[]
> @@ -38,7 +38,8 @@ static inline void pud_clear(pud_t *pud) { }
> * (pmds are folded into puds so this doesn't get actually called,
> * but the define is needed for a generic inline function.)
> */
> -#define set_pud(pudptr, pudval) set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })
> +#define set_pud(pudptr, pudval) (set_pmd((pmd_t *)(pudptr), \
> + (pmd_t) { pudval }))
Not quite so trivial.
If you _really_ want to break this up for 80 columns,
and I don't think it's necessary, it might be better
to use something like:
#define set_pud(pudptr, pudval) \
set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })
next prev parent reply other threads:[~2015-12-15 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 14:15 [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h Chen Gang
2015-12-15 14:20 ` Chen Gang
2015-12-15 15:34 ` kbuild test robot
2015-12-15 15:47 ` kbuild test robot
2015-12-15 15:50 ` Arnd Bergmann
2015-12-15 21:57 ` Chen Gang
2015-12-15 20:26 ` Joe Perches [this message]
2015-12-15 22:06 ` Chen Gang
2015-12-15 20:29 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450211204.4142.30.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=chengang@emindsoft.com.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox