From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933692AbbLOU0u (ORCPT ); Tue, 15 Dec 2015 15:26:50 -0500 Received: from smtprelay0004.hostedemail.com ([216.40.44.4]:59728 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754187AbbLOU0s (ORCPT ); Tue, 15 Dec 2015 15:26:48 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1978:1981:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3150:3352:3622:3865:3867:3868:3871:3872:3873:4321:5007:6117:6261:6691:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13255:13311:13357:13894:14659:21062:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: frogs74_1de6ef3337a35 X-Filterd-Recvd-Size: 1716 Message-ID: <1450211204.4142.30.camel@perches.com> Subject: Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h From: Joe Perches To: Chen Gang , Arnd Bergmann , trivial@kernel.org Cc: Linux-Arch , "linux-kernel@vger.kernel.org" Date: Tue, 15 Dec 2015 12:26:44 -0800 In-Reply-To: <56702088.9080605@emindsoft.com.cn> References: <56702088.9080605@emindsoft.com.cn> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.2-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-12-15 at 22:15 +0800, Chen Gang wrote: > It is a trivial patch. [] > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h [] > @@ -38,7 +38,8 @@ static inline void pud_clear(pud_t *pud) { } >   * (pmds are folded into puds so this doesn't get actually called, >   * but the define is needed for a generic inline function.) >   */ > -#define set_pud(pudptr, pudval) set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval }) > +#define set_pud(pudptr, pudval) (set_pmd((pmd_t *)(pudptr), \ > + (pmd_t) { pudval })) Not quite so trivial. If you _really_ want to break this up for 80 columns, and I don't think it's necessary, it might be better to use something like: #define set_pud(pudptr, pudval) \ set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })