From: Joe Perches <joe@perches.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: Robo Bot <apw@canonical.com>, LKML <linux-kernel@vger.kernel.org>,
Peter Senna Tschudin <peter.senna@gmail.com>
Subject: Re: [BUG] checkpatch: unescaped left brace in regex is deprecated
Date: Tue, 15 Dec 2015 16:13:32 -0800 [thread overview]
Message-ID: <1450224812.4142.39.camel@perches.com> (raw)
In-Reply-To: <CAGG-pUSWfcG2-Wk9vUDyQ6+DJm8kgeUMjMy3=vCUT93DKEAJXA@mail.gmail.com>
On Tue, 2015-12-15 at 20:58 -0300, Geyslan G. Bem wrote:
> 2015-12-10 8:24 GMT-03:00 Geyslan G. Bem <geyslan@gmail.com>:
> > Suggested-by: Peter Senna Tschudin <peter.senna@gmail.com>
> > Reported-by: Geyslan G. Bem <geyslan@gmail.com>
> >
>
> Joe, do you applied this patch? If not, would I send it?
You can resend, but I believe there are a few more instances
of this that might need fixing too.
I don't have perl 5.22 so it's difficult for me to test.
Here's a grep with some possible false positives
and maybe missing some too.
$ git grep -n "=[\!~].*{" scripts/checkpatch.pl|grep -vw qr|grep -vP '{$|{\s*#|\${|\\{|{[\d$]'
scripts/checkpatch.pl:1143: $remainder =~ /^(else)(?:\s|{)/ &&
scripts/checkpatch.pl:1233: $stmt =~ s/^\s*{//;
scripts/checkpatch.pl:2458: if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
scripts/checkpatch.pl:2802: if ($line =~ /^\+(.*)\(\s*$Type\s*\)([ \t]++)((?![={]|\\$|$Attribute|__attribute__))/ &&
scripts/checkpatch.pl:3015: $s =~ s/{.*$//s;
scripts/checkpatch.pl:3168: $s =~ s/^\s*{//;
scripts/checkpatch.pl:3274: if ($line =~ /^.\s*{/ &&
scripts/checkpatch.pl:3282: $fixedline =~ s/\s*=\s*$/ = {/;
scripts/checkpatch.pl:3285: $fixedline =~ s/^(.\s*){\s*/$1/;
scripts/checkpatch.pl:3606: if (($line=~/$Type\s*$Ident\(.*\).*\s*{/) and
scripts/checkpatch.pl:3613: $fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*){(.*)$/;
scripts/checkpatch.pl:3625: if ($line =~ /^.\s*{/ &&
scripts/checkpatch.pl:3635: $fixedline =~ s/^(.\s*){\s*/$1\t/;
scripts/checkpatch.pl:4104:## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
scripts/checkpatch.pl:4124: $fixed[$fixlinenr] =~ s/^(\+.*(?:do|\))){/$1 {/;
scripts/checkpatch.pl:4734: $seen++ if ($block =~ /^\s*{/);
next prev parent reply other threads:[~2015-12-16 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 22:53 [BUG] checkpatch: unescaped left brace in regex is deprecated Geyslan G. Bem
2015-12-07 23:06 ` Joe Perches
2015-12-07 23:36 ` Geyslan G. Bem
[not found] ` <CAGG-pUQsUnAx2rTTgoX4WhUHNGo3R=9siqAVhaOsqB=P9eqnSg@mail.gmail.com>
2015-12-10 11:24 ` Geyslan G. Bem
2015-12-15 23:58 ` Geyslan G. Bem
2015-12-16 0:13 ` Joe Perches [this message]
2015-12-16 11:21 ` Geyslan G. Bem
2015-12-30 15:52 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450224812.4142.39.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=geyslan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox