From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org, peterz@infradead.org
Cc: jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, namhyung@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales
Date: Tue, 15 Dec 2015 16:54:19 -0800 [thread overview]
Message-ID: <1450227266-2501-4-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1450227266-2501-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
When the scaling factor is a full integer don't display fractional
digits. This avoids unnecessary .00 output for topdown metrics
with scale factors.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-stat.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 0c7cdda..1faa6fc 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -63,6 +63,7 @@
#include <stdlib.h>
#include <sys/prctl.h>
#include <locale.h>
+#include <math.h>
#define DEFAULT_SEPARATOR " "
#define CNTR_NOT_SUPPORTED "<not supported>"
@@ -739,12 +740,12 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
const char *fmt;
if (csv_output) {
- fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
+ fmt = sc != 1.0 && floor(sc) != sc ? "%.2f%s" : "%.0f%s";
} else {
if (big_num)
- fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
+ fmt = sc != 1.0 && floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
else
- fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
+ fmt = sc != 1.0 && floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
}
aggr_printout(evsel, id, nr);
--
2.4.3
next prev parent reply other threads:[~2015-12-16 0:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 0:54 Add top down metrics to perf stat v2 Andi Kleen
2015-12-16 0:54 ` [PATCH 01/10] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2015-12-21 16:08 ` Jiri Olsa
2015-12-16 0:54 ` [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases Andi Kleen
2015-12-16 14:16 ` Stephane Eranian
2015-12-21 16:14 ` Jiri Olsa
2015-12-21 16:16 ` Jiri Olsa
2015-12-16 0:54 ` Andi Kleen [this message]
2015-12-16 14:22 ` [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales Stephane Eranian
2015-12-16 0:54 ` [PATCH 04/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2015-12-16 0:54 ` [PATCH 05/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2015-12-16 14:32 ` Stephane Eranian
2015-12-16 21:21 ` Andi Kleen
2015-12-17 9:26 ` Stephane Eranian
2015-12-17 14:03 ` Andi Kleen
2015-12-16 0:54 ` [PATCH 06/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2015-12-16 0:54 ` [PATCH 07/10] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2015-12-16 0:54 ` [PATCH 08/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2015-12-16 8:53 ` Peter Zijlstra
2015-12-16 12:48 ` Stephane Eranian
2015-12-16 16:26 ` Andi Kleen
2015-12-16 0:54 ` [PATCH 09/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2015-12-16 0:54 ` [PATCH 10/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2015-12-17 10:27 ` Add top down metrics to perf stat v2 Stephane Eranian
2015-12-17 14:01 ` Andi Kleen
2015-12-17 23:31 ` Stephane Eranian
2015-12-18 1:55 ` Andi Kleen
2015-12-18 9:31 ` Stephane Eranian
2015-12-18 21:38 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450227266-2501-4-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox