public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org, peterz@infradead.org
Cc: jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
	eranian@google.com, namhyung@kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 04/10] perf, tools, stat: Scale values by unit before metrics
Date: Tue, 15 Dec 2015 16:54:20 -0800	[thread overview]
Message-ID: <1450227266-2501-5-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1450227266-2501-1-git-send-email-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

Scale values by unit before passing them to the metrics printing functions.
This is needed for TopDown, because it needs to scale the slots correctly
by pipeline width / SMTness.

For existing metrics it shouldn't make any difference, as those generally
use events that don't have any units.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/stat.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 2d9d830..913d236 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -307,6 +307,7 @@ int perf_stat_process_counter(struct perf_stat_config *config,
 	struct perf_counts_values *aggr = &counter->counts->aggr;
 	struct perf_stat_evsel *ps = counter->priv;
 	u64 *count = counter->counts->aggr.values;
+	u64 val;
 	int i, ret;
 
 	aggr->val = aggr->ena = aggr->run = 0;
@@ -337,7 +338,8 @@ int perf_stat_process_counter(struct perf_stat_config *config,
 	/*
 	 * Save the full runtime - to allow normalization during printout:
 	 */
-	perf_stat__update_shadow_stats(counter, count, 0);
+	val = counter->scale * *count;
+	perf_stat__update_shadow_stats(counter, &val, 0);
 
 	return 0;
 }
-- 
2.4.3


  parent reply	other threads:[~2015-12-16  0:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16  0:54 Add top down metrics to perf stat v2 Andi Kleen
2015-12-16  0:54 ` [PATCH 01/10] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2015-12-21 16:08   ` Jiri Olsa
2015-12-16  0:54 ` [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases Andi Kleen
2015-12-16 14:16   ` Stephane Eranian
2015-12-21 16:14   ` Jiri Olsa
2015-12-21 16:16   ` Jiri Olsa
2015-12-16  0:54 ` [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2015-12-16 14:22   ` Stephane Eranian
2015-12-16  0:54 ` Andi Kleen [this message]
2015-12-16  0:54 ` [PATCH 05/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2015-12-16 14:32   ` Stephane Eranian
2015-12-16 21:21     ` Andi Kleen
2015-12-17  9:26       ` Stephane Eranian
2015-12-17 14:03         ` Andi Kleen
2015-12-16  0:54 ` [PATCH 06/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2015-12-16  0:54 ` [PATCH 07/10] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2015-12-16  0:54 ` [PATCH 08/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2015-12-16  8:53   ` Peter Zijlstra
2015-12-16 12:48   ` Stephane Eranian
2015-12-16 16:26     ` Andi Kleen
2015-12-16  0:54 ` [PATCH 09/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2015-12-16  0:54 ` [PATCH 10/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2015-12-17 10:27 ` Add top down metrics to perf stat v2 Stephane Eranian
2015-12-17 14:01   ` Andi Kleen
2015-12-17 23:31     ` Stephane Eranian
2015-12-18  1:55       ` Andi Kleen
2015-12-18  9:31         ` Stephane Eranian
2015-12-18 21:38           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450227266-2501-5-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox