From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Noel Grandin <noelgrandin@gmail.com>
Subject: [PATCH 2/6] perf tools: Make perf_evlist__open() open evsels with their cpus and threads (like perf record does)
Date: Thu, 17 Dec 2015 21:26:51 +0100 [thread overview]
Message-ID: <1450384015-12367-3-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1450384015-12367-1-git-send-email-jolsa@kernel.org>
From: Adrian Hunter <adrian.hunter@intel.com>
'perf record' uses perf_evsel__open() to open events and passes the evsel->cpus
and evsel->threads. Many tests and some tools instead use perf_evlist__open()
which passes instead evlist->cpus and evlist->threads.
Make perf_evlist__open() follow the 'perf record' behaviour so that a consistent
approach is taken.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/evlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 05efa910a090..43f4c400a171 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1428,7 +1428,7 @@ int perf_evlist__open(struct perf_evlist *evlist)
perf_evlist__update_id_pos(evlist);
evlist__for_each(evlist, evsel) {
- err = perf_evsel__open(evsel, evlist->cpus, evlist->threads);
+ err = perf_evsel__open(evsel, evsel->cpus, evsel->threads);
if (err < 0)
goto out_err;
}
--
2.4.3
next prev parent reply other threads:[~2015-12-17 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 20:26 [PATCH 0/6] perf tools: Various fixes Jiri Olsa
2015-12-17 20:26 ` [PATCH 1/6] perf tools: Remove perf_evlist__(enable|disable)_event functions Jiri Olsa
2015-12-17 20:26 ` Jiri Olsa [this message]
2015-12-17 20:26 ` [PATCH 3/6] perf tools: Use find_map function in access_dso_mem Jiri Olsa
2015-12-17 20:26 ` [PATCH 4/6] perf tools libunwind: Check for mmaps also in MAP__VARIABLE tree Jiri Olsa
2015-12-17 20:26 ` [PATCH 5/6] perf tools libdw: " Jiri Olsa
2015-12-17 20:26 ` [PATCH 6/6] perf record: Always store data mmaps Jiri Olsa
2016-01-05 11:16 ` Namhyung Kim
2016-01-05 14:11 ` Jiri Olsa
2015-12-17 20:49 ` [PATCH 0/6] perf tools: Various fixes Jiri Olsa
2015-12-18 9:06 ` Noel Grandin
2015-12-27 11:57 ` Jiri Olsa
2016-01-05 10:23 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450384015-12367-3-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=noelgrandin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox