public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Noel Grandin <noelgrandin@gmail.com>
Subject: [PATCH 3/6] perf tools: Use find_map function in access_dso_mem
Date: Thu, 17 Dec 2015 21:26:52 +0100	[thread overview]
Message-ID: <1450384015-12367-4-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1450384015-12367-1-git-send-email-jolsa@kernel.org>

The find_map helper is already there, so let's use it.

Also we're going to introduce wider search in following
patch, so it'll be easier to make this change on single
place.

Link: http://lkml.kernel.org/n/tip-9grtz49b9i4ysfzmuf9z5txj@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/unwind-libunwind.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
index 3c258a0e4092..f37859c04317 100644
--- a/tools/perf/util/unwind-libunwind.c
+++ b/tools/perf/util/unwind-libunwind.c
@@ -416,20 +416,19 @@ get_proc_name(unw_addr_space_t __maybe_unused as,
 static int access_dso_mem(struct unwind_info *ui, unw_word_t addr,
 			  unw_word_t *data)
 {
-	struct addr_location al;
+	struct map *map;
 	ssize_t size;
 
-	thread__find_addr_map(ui->thread, PERF_RECORD_MISC_USER,
-			      MAP__FUNCTION, addr, &al);
-	if (!al.map) {
+	map = find_map(addr, ui);
+	if (!map) {
 		pr_debug("unwind: no map for %lx\n", (unsigned long)addr);
 		return -1;
 	}
 
-	if (!al.map->dso)
+	if (!map->dso)
 		return -1;
 
-	size = dso__data_read_addr(al.map->dso, al.map, ui->machine,
+	size = dso__data_read_addr(map->dso, map, ui->machine,
 				   addr, (u8 *) data, sizeof(*data));
 
 	return !(size == sizeof(*data));
-- 
2.4.3


  parent reply	other threads:[~2015-12-17 20:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 20:26 [PATCH 0/6] perf tools: Various fixes Jiri Olsa
2015-12-17 20:26 ` [PATCH 1/6] perf tools: Remove perf_evlist__(enable|disable)_event functions Jiri Olsa
2015-12-17 20:26 ` [PATCH 2/6] perf tools: Make perf_evlist__open() open evsels with their cpus and threads (like perf record does) Jiri Olsa
2015-12-17 20:26 ` Jiri Olsa [this message]
2015-12-17 20:26 ` [PATCH 4/6] perf tools libunwind: Check for mmaps also in MAP__VARIABLE tree Jiri Olsa
2015-12-17 20:26 ` [PATCH 5/6] perf tools libdw: " Jiri Olsa
2015-12-17 20:26 ` [PATCH 6/6] perf record: Always store data mmaps Jiri Olsa
2016-01-05 11:16   ` Namhyung Kim
2016-01-05 14:11     ` Jiri Olsa
2015-12-17 20:49 ` [PATCH 0/6] perf tools: Various fixes Jiri Olsa
2015-12-18  9:06 ` Noel Grandin
2015-12-27 11:57   ` Jiri Olsa
2016-01-05 10:23     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450384015-12367-4-git-send-email-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=noelgrandin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox