From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751770AbcAAKNx (ORCPT ); Fri, 1 Jan 2016 05:13:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbcAAKNv (ORCPT ); Fri, 1 Jan 2016 05:13:51 -0500 Date: Fri, 1 Jan 2016 12:13:48 +0200 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Petr Mladek , virtualization@lists.linux-foundation.org, Jeff Epler , Tejun Heo , Jiri Kosina Subject: [PATCH RFC] virtio_balloon: refill by config handler Message-ID: <1451643122-21561-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mutt-Fcc: =sent Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Mladek reported that balloon might never refill completely after restore. This is because fill_balloon is only called once there. Calling fill_balloon repeatedly seems too aggressive, especially in light of the fact that it sleeps on failure: let's wake the config change handler and fill it asynchronously. Reported-by: Petr Mladek Signed-off-by: Michael S. Tsirkin --- I was unable to test this - for some reason my test VM doesn't resume (with or without the patch). Petr, does this work for you? drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7efc329..ee29473 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -589,7 +589,7 @@ static int virtballoon_restore(struct virtio_device *vdev) virtio_device_ready(vdev); - fill_balloon(vb, towards_target(vb)); + wake_up(&vb->config_change); update_balloon_size(vb); return 0; } -- MST