From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbcACSU5 (ORCPT ); Sun, 3 Jan 2016 13:20:57 -0500 Received: from smtprelay0233.hostedemail.com ([216.40.44.233]:51224 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751345AbcACSUw (ORCPT ); Sun, 3 Jan 2016 13:20:52 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2197:2198:2199:2200:2201:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4823:5007:6261:9108:10004:10400:10848:10967:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:13894:14659:21080:21221:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: note26_2455f1807a802 X-Filterd-Recvd-Size: 2445 Message-ID: <1451845248.4334.41.camel@perches.com> Subject: Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp From: Joe Perches To: One Thousand Gnomes Cc: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 03 Jan 2016 10:20:48 -0800 In-Reply-To: <20160103141051.2d46c245@lxorguk.ukuu.org.uk> References: <20160103050501.042035135@telegraphics.com.au> <20160103050520.752909053@telegraphics.com.au> <1451807668.4334.38.camel@perches.com> <20160103141051.2d46c245@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-01-03 at 14:10 +0000, One Thousand Gnomes wrote: > On Sat, 02 Jan 2016 23:54:28 -0800 > Joe Perches wrote: > > > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > > Hanging indentation was a poor choice for the text inside comments. It > > > has been used in the wrong places and done badly elsewhere. There is > > > little consistency within any file. One fork of the core driver uses > > > tabs for this indentation while the other uses spaces. Better to use > > > flush-left alignment throughout. > > > > > > This patch is the result of the following substitution. It replaces tabs > > > and spaces at the start of a comment line with a single space. > > > > > > perl -i -pe 's,^(\t*[/ ]\*)[ \t]+,$1 ,' drivers/scsi/{atari_,}NCR5380.c  > > > > > > This removes some unimportant discrepancies between the two core driver > > > forks so that the important ones become obvious, to facilitate > > > reunification. > > > > I still think this patch is poor at best and > > overall not useful. > > I would beg to differ. As a tool for understanding the differences as you > step through the versions it's invaluable. This removes intentional formatting that makes reading comments easier. diff -w works well.