From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002AbcADSuF (ORCPT ); Mon, 4 Jan 2016 13:50:05 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36738 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbcADSt4 (ORCPT ); Mon, 4 Jan 2016 13:49:56 -0500 From: Mathieu OTHACEHE To: johan@kernel.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Mathieu OTHACEHE Subject: [PATCH v2 3/4] USB: mxu11x0: remove duplicated set_termios call Date: Mon, 4 Jan 2016 19:49:38 +0100 Message-Id: <1451933379-21994-4-git-send-email-m.othacehe@gmail.com> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1451933379-21994-1-git-send-email-m.othacehe@gmail.com> References: <1451933379-21994-1-git-send-email-m.othacehe@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function mxu1_set_termios is called twice in open callback. Only the first call is necessary. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/mxu11x0.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c index 7ad2727..6326cda 100644 --- a/drivers/usb/serial/mxu11x0.c +++ b/drivers/usb/serial/mxu11x0.c @@ -830,9 +830,6 @@ static int mxu1_open(struct tty_struct *tty, struct usb_serial_port *port) usb_clear_halt(serial->dev, port->write_urb->pipe); usb_clear_halt(serial->dev, port->read_urb->pipe); - if (tty) - mxu1_set_termios(tty, port, NULL); - status = usb_serial_generic_open(tty, port); if (status) goto unlink_int_urb; -- 2.6.4