From: Alex Williamson <alex.williamson@redhat.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
sebott@linux.vnet.ibm.com
Subject: Re: [PATCH] vfio/iommu_type1: make use of info.flags
Date: Mon, 04 Jan 2016 16:39:45 -0700 [thread overview]
Message-ID: <1451950785.2874.2.camel@redhat.com> (raw)
In-Reply-To: <1450872485-5271-1-git-send-email-pmorel@linux.vnet.ibm.com>
On Wed, 2015-12-23 at 13:08 +0100, Pierre Morel wrote:
> The flags entry is there to tell the user that some
> optional information is available.
>
> Since we report the iova_pgsizes signal it to the user
> by setting the flags to VFIO_IOMMU_INFO_PGSIZES.
>
> Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
> ---
> drivers/vfio/vfio_iommu_type1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio_iommu_type1.c
> b/drivers/vfio/vfio_iommu_type1.c
> index 59d47cb..6f1ea3d 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -995,7 +995,7 @@ static long vfio_iommu_type1_ioctl(void
> *iommu_data,
> if (info.argsz < minsz)
> return -EINVAL;
>
> - info.flags = 0;
> + info.flags = VFIO_IOMMU_INFO_PGSIZES;
>
> info.iova_pgsizes = vfio_pgsize_bitmap(iommu);
>
Applied to my next branch for v4.5, thanks!
Alex
PS - I haven't lost your qemu overflow patch, sorry for the delay.
prev parent reply other threads:[~2016-01-04 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:08 [PATCH] vfio/iommu_type1: make use of info.flags Pierre Morel
2016-01-04 23:39 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451950785.2874.2.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmorel@linux.vnet.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).