From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753979AbcAECkr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 21:40:47 -0500
Received: from smtprelay0067.hostedemail.com ([216.40.44.67]:36281 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753842AbcAECkp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 21:40:45 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1461:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3867:3871:3873:4321:5007:6261:7903:10004:10400:10848:11658:11783:11914:12043:12517:12519:12555:12740:13069:13163:13229:13311:13357:13894:14659:21080:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:31,LUA_SUMMARY:none
X-HE-Tag: sort23_5d920f505f61d
X-Filterd-Recvd-Size: 2227
Message-ID: <1451961641.4334.120.camel@perches.com>
Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space
 after cast
From: Joe Perches <joe@perches.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        LKML <linux-kernel@vger.kernel.org>, linux-usb@vger.kernel.org
Date: Mon, 04 Jan 2016 18:40:41 -0800
In-Reply-To: <CAGG-pUQ1SCm08iJbEsNdhoGTwia1xMorvchWhs8qpMXZBSYUrA@mail.gmail.com>
References: <11dd04072f65c0b168a9d842549c3705a34076b3.1451937845.git.geyslan@gmail.com>
	 <Pine.LNX.4.44L0.1601041551070.1324-100000@iolanthe.rowland.org>
	 <CAGG-pURUsu32SrQTjOvogQVHJr_1QegO6eoRiU-CmQkufw9KhQ@mail.gmail.com>
	 <20160104214924.GA13959@kroah.com> <568AE98A.4030103@cogentembedded.com>
	 <CAGG-pUQ1SCm08iJbEsNdhoGTwia1xMorvchWhs8qpMXZBSYUrA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.3-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-01-04 at 19:07 -0300, Geyslan G. Bem wrote:
> 2016-01-04 18:52 GMT-03:00 Sergei Shtylyov :
> > > > > > This patch fixes coding style issues reported by checkpatch concerning
> > > > > > to unnecessary space after a cast.
> > > > > This is a case where checkpatch is wrong, IMO.  Casts should always be
> > > > > followed by a space.  I will not accept this patch.

Your choice, but most kernel code disagrees with you.

measuring only kernel casts to a pointer, (because there are
too many false positives otherwise) casts without a space
are preferred ~3:1 over casts followed by a space.

(without space)
$ grep -rP --include=*.[ch] -oh "\(\s*(\w{3,}\s+){0,2}\w{3,}\s*\*+\s*\)\w+" * | \
  sort|cut -f1 -d")"| sed 's/$/)/' | wc -l
36612

(with space)
$ grep -rP --include=*.[ch] -oh "\(\s*(\w{3,}\s+){0,2}\w{3,}\s*\*+\s*\)[ \t]\w+" * | \
  sort|cut -f1 -d")"| sed 's/$/)/' | wc -l
13233