From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbcAEK7e (ORCPT ); Tue, 5 Jan 2016 05:59:34 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34902 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbcAEK7b (ORCPT ); Tue, 5 Jan 2016 05:59:31 -0500 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Steven Rostedt , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: [PATCH v2 1/5] perf tools: Fix segfault when using -s trace_fields Date: Tue, 5 Jan 2016 19:58:34 +0900 Message-Id: <1451991518-25673-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.6.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the 'trace_fields' sort key is used explicitly for non-tracepoint events, it'll get segfault since it assumed evsel->tp_format was set. Skip those events in add_all_dynamic_fields(). Acked-by: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/util/sort.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index e558e87cafaf..59c4c8586d79 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -1955,6 +1955,9 @@ static int add_all_dynamic_fields(struct perf_evlist *evlist, bool raw_trace) struct perf_evsel *evsel; evlist__for_each(evlist, evsel) { + if (evsel->attr.type != PERF_TYPE_TRACEPOINT) + continue; + ret = add_evsel_fields(evsel, raw_trace); if (ret < 0) return ret; -- 2.6.4