From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbcAEPUh (ORCPT ); Tue, 5 Jan 2016 10:20:37 -0500 Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:40301 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752324AbcAEPUc (ORCPT ); Tue, 5 Jan 2016 10:20:32 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2561:2564:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6117:6261:8599:9010:9025:9388:10004:10400:10848:11232:11253:11658:11783:11914:12043:12214:12296:12517:12519:12740:12776:13069:13095:13311:13357:13894:14651:14659:21080:30054:30059:30075:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: spot31_216f7aff47631 X-Filterd-Recvd-Size: 2184 Message-ID: <1452007227.4334.133.camel@perches.com> Subject: Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions From: Joe Perches To: Alan Stern , "Geyslan G. Bem" Cc: LKML , Greg Kroah-Hartman , linux-usb@vger.kernel.org Date: Tue, 05 Jan 2016 07:20:27 -0800 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote: > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > > > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct > ehci_hcd *ehci, __hc32 token) > > >>       return '/'; > > >>  } > > >> > > >> -static void qh_lines( > > >> -     struct ehci_hcd *ehci, > > >> -     struct ehci_qh *qh, > > >> -     char **nextp, > > >> -     unsigned *sizep > > >> -) > > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh, > > >> +                     char **nextp, unsigned *sizep) > > >>  { > > >>       u32                     scratch; > > >>       u32                     hw_curr; > > >> > > > > > And about that style? Should be done? > > You mean squeezing the function parameters into two lines?  That's  > okay. > > However, the style in this file is to indent continuation lines by > two > extra tab stops, not to line things up with an open paren on the > first > line. > > Alan Stern > > -- > To unsubscribe from this list: send the line "unsubscribe linux- > kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Please read the FAQ at  http://www.tux.org/lkml/